FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

docs(hermetic-build): indicate usage of Docker Buildkit in development guide by diegomarquezp · Pull Request #3337 · googleapis/sdk-platform-java · GitHub

This repository was archived by the owner on May 14, 2026. It is now read-only.
/ sdk-platform-java Public archive

docs(hermetic-build): indicate usage of Docker Buildkit in development guide #3337

Merged
diegomarquezp merged 4 commits into from
Nov 6, 2024
Conversation 6 Commits 4 Checks 0 Files changed
Merged

docs(hermetic-build): indicate usage of Docker Buildkit in development guide #3337

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
019c369
docs(hermetic-build): indicate usage of Docker Buildkit in developmen…
diegomarquezp Nov 6, 2024
47757bf
Update hermetic_build/DEVELOPMENT.md
diegomarquezp Nov 6, 2024
23693a2
Update DEVELOPMENT.md
diegomarquezp Nov 6, 2024
c8fa84d
Update DEVELOPMENT.md
diegomarquezp Nov 6, 2024
File filter

Filter by extension

Filter by extension .md  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
11 changes: 8 additions & 3 deletions hermetic_build/DEVELOPMENT.md
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -160,13 +160,18 @@ python hermetic_build/library_generation/cli/entry_point.py generate \
1. Run the following command to build the image from source

```shell
docker build \
DOCKER_BUILDKIT=1 docker build \

blakeli0 Nov 6, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can we mention that DOCKER_BUILDKIT=1 is only needed for local development on CloudTop but not needed in CloudBuild?

diegomarquezp Nov 6, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Added a note below.
-f .cloudbuild/library_generation/library_generation.Dockerfile \
-t local:image-tag \
.
```
Please note that the build only works when using the new
[Docker BuildKit](https://docs.docker.com/build/buildkit/) (enabled through the `DOCKER_BUILDKIT` variable).
This is meant for local development only (in CloudTops) - GH Actions' Ubuntu-22.04 \
[comes with the latest Docker version](https://github.com/actions/runner-images/blob/e74605cd6d5407469cf224802f25057bafc23d70/images/ubuntu/Ubuntu2204-Readme.md?plain=1#L81-L83)
and is able to handle the build properly using the (updated) legacy builder.

2. Set the version of gapic-generator-java
3. Set the version of gapic-generator-java
Comment thread
diegomarquezp marked this conversation as resolved.

```shell
LOCAL_GENERATOR_VERSION=$(mvn \
Expand All @@ -177,7 +182,7 @@ python hermetic_build/library_generation/cli/entry_point.py generate \
-q)
```

3. Run the image
4. Run the image

```shell
# Assume you want to generate the library in the current working directory
Expand Down
Back | FazBrowse Home | New Git URL