Shade antlr-runtime - #2854
Merged
bbakerman merged 2 commits intoJun 14, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
dondonz
commented
Jun 12, 2022
Comment thread
src/main/java/graphql/execution/ExecutionContext.java
| } | ||
|
|
||
| /** | ||
| * @return map of coerced variables |
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
Fixing up javadoc warnings, unrelated to antlr
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Very excited to see this! The antlr runtime has prevented us from using graphql-java in systems that use incompatible antlr versions. |
Sorry, something went wrong.
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR shades antlr-runtime and removes it off the pom.
antlr-runtime version clashes can be a blocker as described in #2809 and openrewrite/rewrite#1615