Added support for Flow publishers coming back from the subscription field data fetcher - #3910
Merged
bbakerman merged 1 commit intoJul 1, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…ield data fetcher
Copy link
Copy Markdown
Contributor
Test Results 313 files ±0 313 suites ±0 55s ⏱️ -1s Results for commit 93a66bb. ± Comparison against base commit 1318a24. This pull request removes 192 and adds 174 tests. Note that renamed tests count towards both. ?
__schema { types { fields { args { type { name fields { name }}}}}}
__schema { types { fields { type { name fields { name }}}}}
__schema { types { inputFields { type { inputFields { name }}}}}
__schema { types { interfaces { fields { type { interfaces { name } } } } } }
__schema { types { name} }
__type(name : "t") { name }
a1: __schema { types { name} }
a1: __type(name : "t") { name }
a2 : __type(name : "t1") { name }
…
graphql.AssertTest ‑ assertFalse with different number of error args but false does not throw assertions [toRun: <graphql.AssertTest$__spock_feature_0_21prov0_closure23@3f4b840d delegate=graphql.AssertTest@54aca26f owner=graphql.AssertTest@54aca26f thisObject=graphql.AssertTest@54aca26f resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1, #0] graphql.AssertTest ‑ assertFalse with different number of error args but false does not throw assertions [toRun: <graphql.AssertTest$__spock_feature_0_21prov0_closure24@68c87fc3 delegate=graphql.AssertTest@54aca26f owner=graphql.AssertTest@54aca26f thisObject=graphql.AssertTest@54aca26f resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1 arg2, #1] graphql.AssertTest ‑ assertFalse with different number of error args but false does not throw assertions [toRun: <graphql.AssertTest$__spock_feature_0_21prov0_closure25@bc0f53b delegate=graphql.AssertTest@54aca26f owner=graphql.AssertTest@54aca26f thisObject=graphql.AssertTest@54aca26f resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1 arg2 arg3, #2] graphql.AssertTest ‑ assertFalse with different number of error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_20prov0_closure20@33f98231 delegate=graphql.AssertTest@54aca26f owner=graphql.AssertTest@54aca26f thisObject=graphql.AssertTest@54aca26f resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1, #0] graphql.AssertTest ‑ assertFalse with different number of error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_20prov0_closure21@48284d0e delegate=graphql.AssertTest@54aca26f owner=graphql.AssertTest@54aca26f thisObject=graphql.AssertTest@54aca26f resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1 arg2, #1] graphql.AssertTest ‑ assertFalse with different number of error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_20prov0_closure22@557286ad delegate=graphql.AssertTest@54aca26f owner=graphql.AssertTest@54aca26f thisObject=graphql.AssertTest@54aca26f resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1 arg2 arg3, #2] graphql.AssertTest ‑ assertNotNull with different number of error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_5prov0_closure3@2ff95fc6 delegate=graphql.AssertTest@54aca26f owner=graphql.AssertTest@54aca26f thisObject=graphql.AssertTest@54aca26f resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1, #0] graphql.AssertTest ‑ assertNotNull with different number of error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_5prov0_closure4@ea9e141 delegate=graphql.AssertTest@54aca26f owner=graphql.AssertTest@54aca26f thisObject=graphql.AssertTest@54aca26f resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1 arg2, #1] graphql.AssertTest ‑ assertNotNull with different number of error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_5prov0_closure5@236134a1 delegate=graphql.AssertTest@54aca26f owner=graphql.AssertTest@54aca26f thisObject=graphql.AssertTest@54aca26f resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1 arg2 arg3, #2] graphql.AssertTest ‑ assertNotNull with different number of error args with non null does not throw assertions [toRun: <graphql.AssertTest$__spock_feature_0_6prov0_closure6@c6e0f32 delegate=graphql.AssertTest@54aca26f owner=graphql.AssertTest@54aca26f thisObject=graphql.AssertTest@54aca26f resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1, #0] … |
Sorry, something went wrong.
bbakerman
commented
Apr 10, 2025
| SubscriptionPublisher mapSourceToResponse = new SubscriptionPublisher(publisher, mapperFunction, keepOrdered); | ||
| ExecutionResultImpl executionResult = new ExecutionResultImpl(mapSourceToResponse, executionContext.getErrors()); | ||
| return executionResult; | ||
| return new ExecutionResultImpl(mapSourceToResponse, executionContext.getErrors()); |
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
just redundant variables cleanup
Sorry, something went wrong.
bbakerman
commented
Apr 10, 2025
| }; | ||
| } | ||
|
|
||
| } |
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
Moved this code into CommonMessagePublisher for re-use reasons
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows an implementation to return a Flow.Publisher in their data fetcher
It will be converted to a reactive streams publisher when it comes back out of the ExecutionResult.