Introduce a filter and map imperative method to replace .stream() calls - #3931
Merged
dondonz merged 2 commits intoMay 15, 2025
Merged
Introduce a filter and map imperative method to replace .stream() calls#3931dondonz merged 2 commits into
dondonz merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Test Results 314 files ±0 314 suites ±0 53s ⏱️ -1s Results for commit 9066581. ± Comparison against base commit 397c050. This pull request removes 150 and adds 129 tests. Note that renamed tests count towards both. ?
__schema { types { fields { args { type { name fields { name }}}}}}
__schema { types { fields { type { name fields { name }}}}}
__schema { types { inputFields { type { inputFields { name }}}}}
__schema { types { interfaces { fields { type { interfaces { name } } } } } }
__schema { types { name} }
__type(name : "t") { name }
a1: __schema { types { name} }
a1: __type(name : "t") { name }
a2 : __type(name : "t1") { name }
…
graphql.ScalarsBooleanTest ‑ parseValue throws exception for invalid input <java.lang.Object@347684c5> graphql.ScalarsBooleanTest ‑ serialize throws exception for invalid input <java.lang.Object@2d6dcb44> graphql.ScalarsIDTest ‑ parseValue allows any object via String.valueOf <java.lang.Object@1dfd9edb> graphql.ScalarsIDTest ‑ serialize allows any object via String.valueOf <java.lang.Object@6a86e083> graphql.ScalarsIntTest ‑ parseValue throws exception for invalid input <java.lang.Object@570a6057> graphql.ScalarsIntTest ‑ serialize throws exception for invalid input <java.lang.Object@4b6b1cdc> graphql.collect.ImmutableKitTest ‑ flatMapList works graphql.execution.instrumentation.TracingInstrumentationTest ‑ do not trace introspection information [testExecutionStrategy: <graphql.execution.AsyncExecutionStrategy@db4653b fieldCollector=graphql.execution.FieldCollector@65dd9bd3 executionStepInfoFactory=graphql.execution.ExecutionStepInfoFactory@133bbbee dataFetcherExceptionHandler=graphql.execution.SimpleDataFetcherExceptionHandler@661d2661 resolvedType=graphql.execution.ResolveType@48ae1a24>, #0] graphql.execution.instrumentation.TracingInstrumentationTest ‑ do not trace introspection information [testExecutionStrategy: <graphql.execution.AsyncSerialExecutionStrategy@f8e24e0 fieldCollector=graphql.execution.FieldCollector@af255e executionStepInfoFactory=graphql.execution.ExecutionStepInfoFactory@38686055 dataFetcherExceptionHandler=graphql.execution.SimpleDataFetcherExceptionHandler@593247b2 resolvedType=graphql.execution.ResolveType@27e5d150>, #1] graphql.execution.instrumentation.TracingInstrumentationTest ‑ tracing captures timings as expected [testExecutionStrategy: <graphql.execution.AsyncExecutionStrategy@29614219 fieldCollector=graphql.execution.FieldCollector@6ade78a8 executionStepInfoFactory=graphql.execution.ExecutionStepInfoFactory@3a63607f dataFetcherExceptionHandler=graphql.execution.SimpleDataFetcherExceptionHandler@777d3d92 resolvedType=graphql.execution.ResolveType@542fd8ee>, #0] … ♻️ This comment has been updated with latest results. |
Sorry, something went wrong.
dondonz
approved these changes
May 14, 2025
dondonz
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
As a separate note, given how many perf changes are in this release, we should look at the cumulative perf improvements later
Sorry, something went wrong.
…nd-map # Conflicts: # src/main/java/graphql/util/FpKit.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For performance reasons this replaces .stream() calls that build ImmutableLists