FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

ExecutionStepInfo now has a direct transform without a Builder by bbakerman · Pull Request #3934 · graphql-java/graphql-java · GitHub

/ graphql-java Public

ExecutionStepInfo now has a direct transform without a Builder - #3934

Merged
dondonz merged 2 commits into
masterfrom
execution-step-info-without-builder
May 14, 2025
ConversationCommits (2)ChecksFiles changed
Merged

ExecutionStepInfo now has a direct transform without a Builder#3934
dondonz merged 2 commits into
masterfrom
execution-step-info-without-builder

Conversation

bbakerman commented Apr 28, 2025

Copy link
Copy Markdown
Member

This is really 1% stuff. Its debatably faster BUT it uses (slightly) less memory and thats a good thing at scale

Benchmark                                                        (howManyItems)   Mode  Cnt    Score    Error  Units
ExecutionStepInfoBenchmark.benchMarkBuilderThroughput                   1000000  thrpt    4  376.814 ±  7.136  ops/s
ExecutionStepInfoBenchmark.benchMarkBuilderThroughput                   2000000  thrpt    4  188.889 ±  2.585  ops/s
ExecutionStepInfoBenchmark.benchMarkDirectConstructorThroughput         1000000  thrpt    4  379.725 ± 13.369  ops/s
ExecutionStepInfoBenchmark.benchMarkDirectConstructorThroughput         2000000  thrpt    4  191.496 ±  1.785  ops/s

bbakerman added the performance work that is primarily targeted as performance improvements label Apr 28, 2025
bbakerman requested a review from andimarek April 28, 2025 02:16

github-actions Bot commented Apr 28, 2025

Copy link
Copy Markdown
Contributor

Test Results

  312 files    312 suites   54s ⏱️
3 581 tests 3 576 ✅ 5 💤 0 ❌
3 670 runs  3 665 ✅ 5 💤 0 ❌

Results for commit 237d6bb.

bbakerman requested a review from dondonz April 28, 2025 04:41
bbakerman mentioned this pull request Apr 29, 2025
Open
dondonz merged commit 1a760d7 into master May 14, 2025
dondonz mentioned this pull request May 15, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dondonz dondonz approved these changes
andimarek Awaiting requested review from andimarek

Assignees

No one assigned

Labels

performance work that is primarily targeted as performance improvements

Projects

None yet

Milestone

24.0

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL