OSGI - Make org.jspecify.* imports optional - #3949
Merged
bbakerman merged 1 commit intoMay 6, 2025
Merged
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@schulm sounds reasonable. @dondonz @bbakerman thoughts? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Yeah we should add this. |
Sorry, something went wrong.
bbakerman
self-requested a review
May 6, 2025 00:38
bbakerman
approved these changes
May 6, 2025
bbakerman
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Not many use OSGI any more but why not
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
@bbakerman Thanks, would you also have a look at graphql-java/java-dataloader#194 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since org.specify import is not necessarily needed at runtime, can we make it optional?