DataLoader dispatching for Subscriptions - #3988
Merged
andimarek merged 6 commits intoJun 12, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Test Results 318 files 318 suites 2m 29s ⏱️ Results for commit cbd4505. ♻️ This comment has been updated with latest results. |
Sorry, something went wrong.
bbakerman
approved these changes
Jun 9, 2025
bbakerman
approved these changes
Jun 12, 2025
bbakerman
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I went thought the commits that make it pass - nice
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the normal per level data batching to subscriptions events.
Before the dispatching would alway happen directly after a dataloader was used, meaning there was not batching happening.