FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Build and test using Java 25 by yeikel · Pull Request #4173 · graphql-java/graphql-java · GitHub

/ graphql-java Public

Build and test using Java 25 - #4173

Merged
andimarek merged 5 commits into
graphql-java:masterfrom
yeikel:java25
Jan 20, 2026
ConversationCommits (5)ChecksFiles changed
Merged

Build and test using Java 25#4173
andimarek merged 5 commits into
graphql-java:masterfrom
yeikel:java25

Conversation

yeikel commented Nov 16, 2025

Copy link
Copy Markdown
Contributor

Updates the CI and the build to use Java 25

Closes #4119

yeikel mentioned this pull request Nov 16, 2025
Closed
andimarek requested a review from Copilot November 17, 2025 02:27
Copilot AI reviewed Nov 17, 2025
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Pull Request Overview

This PR updates the build configuration and CI workflows to use Java 25 as the primary JDK, while adding Java 21 to the test matrix to ensure backward compatibility testing.

  • Updates GitHub Actions workflows to use JDK 25 instead of JDK 21
  • Adds a new testWithJava21 Gradle task to test backward compatibility with Java 21
  • Updates CI test matrices and test result paths to include Java 21 tests

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
build.gradle Adds testWithJava21 test task and makes it a dependency of the main test task
.github/workflows/release.yml Updates JDK version from 21 to 25 for release builds
.github/workflows/pull_request.yml Updates JDK to 25, adds Java 21 testing to matrix, and includes Java 21 test results
.github/workflows/master.yml Updates JDK to 25, adds Java 21 testing to matrix, and includes Java 21 test results

reneleonhardt commented Nov 17, 2025

Copy link
Copy Markdown

Has testWithJava25 specifically not been added?

yeikel commented Nov 17, 2025

Copy link
Copy Markdown
Contributor Author

Has testWithJava25 specifically not been added?

Based on the previous pattern, my understanding of the build is that this will happen by default

dondonz approved these changes Dec 7, 2025
View reviewed changes

dondonz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for the PR. Could you update for the merge conflict?

yeikel commented Dec 7, 2025

Copy link
Copy Markdown
Contributor Author

Thanks for the PR. Could you update for the merge conflict?

It should be ready now. Thanks!

reneleonhardt commented Dec 8, 2025

Copy link
Copy Markdown

Has testWithJava25 specifically not been added?

Based on the previous pattern, my understanding of the build is that this will happen by default

Could you log the actual JDK being tested just to be sure?

test {
    doFirst {
        println "Running tests with JDK ${System.getProperty('java.version')}"
    }
}

yeikel commented Dec 9, 2025

Copy link
Copy Markdown
Contributor Author

Has testWithJava25 specifically not been added?

Based on the previous pattern, my understanding of the build is that this will happen by default

Could you log the actual JDK being tested just to be sure?

test {
    doFirst {
        println "Running tests with JDK ${System.getProperty('java.version')}"
    }
}

Thanks, I applied your feedback. See https://github.com/graphql-java/graphql-java/actions/runs/20075548260/job/57588814897?pr=4173#step:6:1567

Merge origin/master into java25
1ef99fa 
Resolve conflicts in workflow files:
- Keep testWithJava21 test results
- Keep javadoc job, updated to use JDK 25
Remove debug output and update AGENTS.md for Java 21 tests
20856c5 
- Remove test doFirst block that printed JDK version
- Add testWithJava21 exclusion to AGENTS.md test command
andimarek added the not release related changes which are not released (for example unit tests or docs) label Jan 20, 2026
andimarek merged commit e5f21b8 into graphql-java:master Jan 20, 2026
6 checks passed
yeikel deleted the java25 branch January 20, 2026 04:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
dondonz dondonz approved these changes

Assignees

No one assigned

Labels

not release related changes which are not released (for example unit tests or docs)

Projects

None yet

Milestone

25.1 bugfix & non-breaking changes

Development

Successfully merging this pull request may close these issues.

Build and Test using Java 25

5 participants

Back | FazBrowse Home | New Git URL