Getdataloader type bounds - #4180
Merged
dondonz merged 2 commits intoDec 7, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
The @NullMarked annotation on DataFetchingEnvironment makes type parameters implicitly non-null, but java-dataloader's DataLoader declares V extends @nullable Object to allow nullable values. This mismatch prevents Kotlin consumers from expressing nullable value types without unsafe casts when returning CompletableFuture from data fetchers. Add explicit V extends @nullable Object bound to match DataLoader's type signature, enabling proper nullability propagation to Kotlin.
bbakerman
approved these changes
Nov 25, 2025
bbakerman
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks for this.
Moving to JSpecify is an interesting exercise because while it "allows for more precise nullability specifications" its only the Kotlin compiler that truly enforces it.
So this mismatch for example survives a Java compile but not a Kotlin one.
I wonder if we are missing some Java setting that would catch this earlier
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The @NullMarked annotation on DataFetchingEnvironment makes type parameters implicitly non-null, but java-dataloader's DataLoader declares V extends @nullable Object to allow nullable values.
This mismatch prevents Kotlin consumers from expressing nullable value types without unsafe casts when returning CompletableFuture from data fetchers.
Add explicit V extends @nullable Object bound to match DataLoader's type signature, enabling proper nullability propagation to Kotlin.
#4179