FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix SchemaTransformerBenchmark to pass schema validation by andimarek · Pull Request #4255 · graphql-java/graphql-java · GitHub

/ graphql-java Public

Fix SchemaTransformerBenchmark to pass schema validation #4255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andimarek merged 1 commit into from
Feb 21, 2026
Conversation 1 Commits 1 Checks 10 Files changed
Merged

Fix SchemaTransformerBenchmark to pass schema validation #4255

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .java  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
5 changes: 5 additions & 0 deletions src/jmh/java/benchmark/SchemaTransformerBenchmark.java
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package benchmark;

import graphql.introspection.Introspection.DirectiveLocation;
import graphql.schema.GraphQLDirective;
import graphql.schema.GraphQLFieldDefinition;
import graphql.schema.GraphQLObjectType;
Expand Down Expand Up @@ -42,6 +43,8 @@ public static class MyState {

GraphQLDirective infoDirective = GraphQLDirective.newDirective()
.name("Info")
.validLocation(DirectiveLocation.FIELD_DEFINITION)
.validLocation(DirectiveLocation.OBJECT)
.build();
GraphQLTypeVisitor directiveAdder = new GraphQLTypeVisitorStub() {
@Override
Expand Down Expand Up @@ -94,6 +97,8 @@ public void setup() {
try {
String schemaString = BenchmarkUtils.loadResource("large-schema-3.graphqls");
schema = SchemaGenerator.createdMockedSchema(schemaString);
// Declare the Info directive on the schema so validation passes after transformation
schema = schema.transform(builder -> builder.additionalDirective(infoDirective));
txSchema = SchemaTransformer.transformSchema(schema, directiveAdder);
} catch (Exception e) {
throw new RuntimeException(e);
Expand Down
Loading
Back | FazBrowse Home | New Git URL