FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix build.gradle variable name breaking CI by dondonz · Pull Request #4352 · graphql-java/graphql-java · GitHub

Fix build.gradle variable name breaking CI - #4352

Closed
dondonz wants to merge 1 commit into
claude/agent-team-jspecify-Frd74from
claude/fix-jspecify-build-cmK4F
Closed

Fix build.gradle variable name breaking CI#4352
dondonz wants to merge 1 commit into
claude/agent-team-jspecify-Frd74from
claude/fix-jspecify-build-cmK4F

Conversation

dondonz commented Mar 24, 2026

Copy link
Copy Markdown
Member

Summary

  • Fixes a typo in build.gradle where branchName was incorrectly referenced as sanitizedBranchName in the return statement of getDevelopmentVersion()
  • This caused Gradle project evaluation to fail, which broke all CI jobs (javadoc, tests, checks)

Context

This fixes the CI failures on PR #4274 (JSpecify big wave 3). The variable was declared as branchName on line 91 but referenced as sanitizedBranchName on line 93.

Test plan

  • All CI checks pass after merge

https://claude.ai/code/session_01PGPxo4kJmjmYn4nAgtyMZ6

The variable was renamed from `branchName` to `sanitizedBranchName` in the
return statement but not in the declaration, causing Gradle project evaluation
to fail with "Could not get unknown property 'sanitizedBranchName'". This
broke all CI jobs (javadoc, tests, checks) since the project couldn't configure.

https://claude.ai/code/session_01PGPxo4kJmjmYn4nAgtyMZ6

andimarek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I fixed that on main with my latest PR ... please double check

dondonz commented Mar 24, 2026

Copy link
Copy Markdown
Member Author

Ok great. I might have introduced this bug with a bad merge conflict resolution

dondonz closed this Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL