FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Simplify directive cycle detection by andimarek · Pull Request #4459 · graphql-java/graphql-java · GitHub

/ graphql-java Public

Simplify directive cycle detection - #4459

Open
andimarek wants to merge 1 commit into
masterfrom
codex/simplify-directive-cycle-detection
ConversationCommits (1)ChecksFiles changed
Open

Simplify directive cycle detection#4459
andimarek wants to merge 1 commit into
masterfrom
codex/simplify-directive-cycle-detection

Conversation

andimarek commented Aug 23, 2026

Copy link
Copy Markdown
Member

Summary

  • derive directive and input-type references on demand instead of precomputing a second graph
  • use one ordered active path for cycle detection and diagnostic formatting
  • preserve directive-definition, input object, enum, scalar, and extension cycle handling on master
  • consolidate duplicate cycle tests and add acyclic plus master-specific type coverage

This follows up on the simplification made in #4451 for 26.x, adapted to master’s broader directive-definition and input-type cycle support.

Testing

  • ./gradlew test --tests graphql.schema.idl.SchemaTypeDirectivesCheckerTest --tests graphql.schema.idl.SchemaGeneratorTest --tests graphql.schema.idl.DirectivesOnDirectiveDefinitionsTest
  • ./gradlew clean test (5,753 tests)
  • ./gradlew check -x test -x testng

github-actions Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Test Report

Test Results

Java Version Total Passed Failed Errors Skipped
Java 11 5943 (+3 🟢) 5887 (+3 🟢) 0 (±0) 0 (±0) 56 (±0)
Java 17 5943 (+3 🟢) 5886 (+3 🟢) 0 (±0) 0 (±0) 57 (±0)
Java 21 5943 (+3 🟢) 5886 (+3 🟢) 0 (±0) 0 (±0) 57 (±0)
Java 25 5943 (+3 🟢) 5886 (+3 🟢) 0 (±0) 0 (±0) 57 (±0)
jcstress 32 (±0) 32 (±0) 0 (±0) 0 (±0) 0 (±0)
Total 23804 (+12 🟢) 23577 (+12 🟢) 0 (±0) 0 (±0) 227 (±0)

Code Coverage (Java 25)

Metric Covered Missed Coverage vs Master
Lines 30070 3117 90.6% ±0.0%
Branches 8803 1517 85.3% ±0.0%
Methods 8024 1205 86.9% ±0.0%

Changed Class Coverage (4 classes)

Class Line Branch Method
g.s.i.e.MissingScalarImplementationError +100.0% 🟢 ±0.0% +100.0% 🟢
g.s.i.SchemaTypeChecker +0.6% 🟢 +5.0% 🟢 ±0.0%
g.s.i.SchemaTypeDirectivesChecker ±0.0% ±0.0% -1.4% 🔴
g.s.i.SchemaTypeExtensionsChecker +0.5% 🟢 ±0.0% +1.5% 🟢
SchemaTypeDirectivesChecker — method details
Method Line Branch
directiveReferences new 100.0% —
typeReferences new 100.0% 100.0%
recordReference new 100.0% —
checkIndirectDirectiveCycles new 100.0% 100.0%
checkDirectiveReferencesForCycles new 100.0% 100.0%
referencesFor new 100.0% 100.0%
addIndirectDirectiveCycleError new 100.0% 100.0%
firstDirectiveName new 100.0% 100.0%
rotateAndDisplayCycle new 100.0% 100.0%
lambda$typeReferences$2 new 0.0% —
lambda$typeReferences$1 new 100.0% —
lambda$typeReferences$0 new 100.0% —
lambda$directiveReferences$1 new 100.0% —
lambda$directiveReferences$0 new 100.0% —
referencesByName removed removed
recordDirectiveDefinitionReferences removed removed
recordInputTypeReferences removed removed
recordReference removed removed
checkIndirectDirectiveCycles removed removed
checkIndirectDirectiveCycles removed removed
checkIndirectDirectiveCycleReferences removed removed
checkIndirectDirectiveCycleReference removed removed
addIndirectDirectiveCycleError removed removed
directiveCyclePath removed removed
rotateCyclePath removed removed
lambda$recordReference$0 removed removed
lambda$recordInputTypeReferences$7 removed removed
lambda$recordInputTypeReferences$8 removed removed
lambda$recordInputTypeReferences$6 removed removed
lambda$recordInputTypeReferences$4 removed removed
lambda$recordInputTypeReferences$5 removed removed
lambda$recordInputTypeReferences$3 removed removed
lambda$recordInputTypeReferences$1 removed removed
lambda$recordInputTypeReferences$2 removed removed
lambda$recordInputTypeReferences$0 removed removed
lambda$recordDirectiveDefinitionReferences$1 removed removed
lambda$recordDirectiveDefinitionReferences$0 removed removed
lambda$referencesByName$0 removed removed

Full HTML report: build artifact jacoco-html-report

Updated: 2026-08-23 23:11:45 UTC

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

Back | FazBrowse Home | New Git URL