FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Backport 24.4: Validation cleanup by andimarek · Pull Request #4465 · graphql-java/graphql-java · GitHub

Backport 24.4: Validation cleanup - #4465

Merged
andimarek merged 1 commit into
24.xfrom
codex/backport-4441-to-24.x
Aug 23, 2026
Merged

Backport 24.4: Validation cleanup#4465
andimarek merged 1 commit into
24.xfrom
codex/backport-4441-to-24.x

Conversation

Copy link
Copy Markdown
Member

Backport of #4441 to the 24.x maintenance branch.

The 24.x branch still uses the rule-based validator, so the same linear fragment-cycle algorithm is applied to NoFragmentCycles rather than the newer OperationValidator. The original focused coverage is retained.

Summary:

  • makes fragment cycle validation linear
  • avoids repeatedly copying fragment paths while retaining validation behavior
  • adds focused coverage for large fragment graphs

Testing:

  • RELEASE_VERSION=local-test ./gradlew :test --tests graphql.validation.rules.NoFragmentCyclesTest

Copy link
Copy Markdown
Contributor

Test Results

  312 files    312 suites   57s ⏱️
4 611 tests 4 602 ✅ 9 💤 0 ❌
4 700 runs  4 691 ✅ 9 💤 0 ❌

Results for commit f7246c5.

Copy link
Copy Markdown
Contributor

Test Report

Test Results

Java Version Total Passed Failed Errors Skipped
Java 11 - - - - -
Java 17 - - - - -
Java 21 - - - - -
Java 25 - - - - -
jcstress - - - - -

Updated: 2026-08-23 23:37:01 UTC

andimarek merged commit 37dff54 into 24.x Aug 23, 2026
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL