FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

xds: Add `grpc.target` value for xDS enabled server metrics by DNVindhya · Pull Request #11715 · grpc/grpc-java · GitHub

/ grpc-java Public

xds: Add grpc.target value for xDS enabled server metrics - #11715

Merged
DNVindhya merged 1 commit into
grpc:masterfrom
DNVindhya:xds-client-metrics-for-server
Nov 27, 2024
ConversationCommits (1)ChecksFiles changed
Merged

xds: Add grpc.target value for xDS enabled server metrics#11715
DNVindhya merged 1 commit into
grpc:masterfrom
DNVindhya:xds-client-metrics-for-server

Conversation

DNVindhya commented Nov 27, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

According to gRFC A71 xDS Fallback:

Update CSDS to aggregate configs from multiple XdsClient instances.

The CSDS RPC service will be changed to get data from all XdsClient instances. A new string field named client_scope will be added to the CSDS ClientConfig message to indicate the channel target the data is associated with. For gRPC clients, this field will contain the key channels use to lookup their XdsClient instance, such as dataplane target for client channels or special value "#server" for xDS-enabled gRPC servers.

Updated dataplane target value to "#server" for xDS enabled servers.

The dataplane target value of "#server" will also be used as grpc.target attribute value for xDS client metrics implemented in #11661.

DNVindhya requested a review from ejona86 November 27, 2024 18:16
DNVindhya changed the title xds: Add grpc.target value for xDS enabled servers xds: Add grpc.target value for xDS enabled server metrics Nov 27, 2024
ejona86 approved these changes Nov 27, 2024
View reviewed changes

ejona86 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The better reference here is probably fallback. https://github.com/grpc/proposal/blob/master/A71-xds-fallback.md#update-csds-to-aggregate-configs-from-multiple-xdsclient-instances says servers use #server. The metrics gRFC is just saying "the same thing applies here"

DNVindhya commented Nov 27, 2024

Copy link
Copy Markdown
Contributor Author

The better reference here is probably fallback. https://github.com/grpc/proposal/blob/master/A71-xds-fallback.md#update-csds-to-aggregate-configs-from-multiple-xdsclient-instances says servers use #server. The metrics gRFC is just saying "the same thing applies here"

Thanks for the background, updated PR description to refer to A71 instead.

DNVindhya merged commit ebb43a6 into grpc:master Nov 27, 2024
DNVindhya deleted the xds-client-metrics-for-server branch November 27, 2024 18:59
larry-safran pushed a commit to larry-safran/grpc-java that referenced this pull request Dec 6, 2024
Add "#server" as dataplane target value for xDS enabled gRPC servers. (…
10fe951 
…grpc#11715)

As mentioned in [A71 xDS Fallback]( https://github.com/grpc/proposal/blob/master/A71-xds-fallback.md#update-csds-to-aggregate-configs-from-multiple-xdsclient-instances):
updated dataplane target to "#server" for xDS-enabled gRPC servers.
github-actions Bot locked as resolved and limited conversation to collaborators Feb 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

ejona86 ejona86 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL