Adopt proto_lang_toolchain for java_grpc_library() - #12994
Conversation
Sorry, something went wrong.
| allow_empty = False, | ||
| providers = [JavaInfo], | ||
| ), | ||
| # This attribute has a "magic" name recognized by the native DexArchiveAspect (b/78647825). |
There was a problem hiding this comment.
Why was this comment removed? Did you test that a different attribute name here still works with dexing?
Sorry, something went wrong.
| load("@rules_java//java:defs.bzl", "java_library") | ||
| load("@rules_jvm_external//:defs.bzl", "artifact") | ||
| load("//:java_grpc_library.bzl", "java_rpc_toolchain") | ||
| load("@rules_proto//proto:defs.bzl", "proto_lang_toolchain") |
There was a problem hiding this comment.
I'm surprised to see a usage of @rules_proto, since that repo is dead/archived. Is this a temporary thing to support older Bazel versions and we'll swap to the protobuf repo later?
Sorry, something went wrong.
| java_info = java_common.compile( | ||
| ctx, | ||
| java_toolchain = toolchain.java_toolchain[java_common.JavaToolchainInfo], | ||
| java_toolchain = ctx.toolchains["@bazel_tools//tools/jdk:toolchain_type"].java, |
There was a problem hiding this comment.
I'm surprised to see a literal being passed here. Is that not defined somewhere?
Sorry, something went wrong.
| source_jars = [srcjar], | ||
| output = ctx.outputs.jar, | ||
| output_source_jar = ctx.outputs.srcjar, | ||
| plugins = [plugin[JavaPluginInfo] for plugin in toolchain.java_plugins], |
There was a problem hiding this comment.
It looks like we need to still support this, as there are usages internally. I don't know if that means we need a second toolchain, or what.
Sorry, something went wrong.
Reviewers
At least 1 approving review is required to merge this pull request.
No description provided.