Codecov Report

Merging #313 (eb92f19) into main (dafbb8a) will not change coverage.
The diff coverage is n/a.

❗ Current head eb92f19 differs from pull request most recent head c4e1337. Consider uploading reports for the commit c4e1337 to get more accurate results

@@            Coverage Diff            @@
##              main      #313   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           53        53           
  Lines         1445      1445           
  Branches       186       186           
=========================================
  Hits          1445      1445           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dafbb8a...c4e1337. Read the comment docs.

Unit Test Results

    1 files    49 suites   15s ⏱️
296 tests 296 ✔️ 0 💤 0 ❌
297 runs  297 ✔️ 0 💤 0 ❌

Results for commit eb92f19.

https://github.com/angular/angular-cli/blob/master/.eslintrc.json
Angular cli is now using eslint. We can compare our rules with theirs

@alok-traceable can you please combine the rules files so that we only have one eslintrc.json? Mainly remove base.js.

@aaron-steinfeld We can probably take angularcli rules as a base and add/remove rules on top of it.

@aaron-steinfeld We can probably take angularcli rules as a base and add/remove rules on top of it.

My guess is that angular's own isn't particularly close to what we enforce - last I looked at the angular code, it is far more javascripty than our style.

@alok-traceable can you please combine the rules files so that we only have one eslintrc.json? Mainly remove base.js.

@alok-traceable ping. Can you please take care of this on priority? Then we will have a better idea of what rules are failing and their proper fix.