FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: proper Typescript typings for Seq.concat() by alexvictoor · Pull Request #2040 · immutable-js/immutable-js · GitHub

Repository navigation

fix: proper Typescript typings for Seq.concat() - #2040

Merged
jdeniau merged 1 commit into
immutable-js:mainfrom
alexvictoor:fix-seq-typings
Jan 11, 2025
Merged

jdeniau merged 1 commit into
immutable-js:mainfrom
alexvictoor:fix-seq-typings

Conversation

Copy link
Copy Markdown

This PR fixes an issue occurring when a sequence is typed as a regular Seq (not an IndexedSeq, keyedSeq, ...).
Below a code fragment to reproduce the issue:

let seq = Seq();
seq = seq.concat(1): // TS error here because seq.concat() return type is Collection<unknown, unknown> instead of Seq<unknown, unknown>

jdeniau merged commit a2bc1b4 into immutable-js:main Jan 11, 2025
jdeniau mentioned this pull request Jan 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL