FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

allow TS files to be compiled in src dir by jdeniau · Pull Request #2054 · immutable-js/immutable-js · GitHub

allow TS files to be compiled in src dir - #2054

Merged
jdeniau merged 5 commits into
mainfrom
init-typescript-in-v5
Feb 23, 2025
Merged

jdeniau merged 5 commits into
mainfrom
init-typescript-in-v5

Conversation

jdeniau commented Feb 22, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

The migration to TS will probably occur on two different branches :

  • what we can do on the 5.x branch should be done here, without altering the dist output,
  • what can not be done here should be done on the 6.x branch.

A list of things already spotted that won't be possible on v5 :

  • buble is our actual ES5 compiler, and does not works well with typescript output or even modern code (string interpolation, class props, etc.),
  • In the immutable codebase, the class constructor are factories that can create instances of other classes. This is not possible in modern JS. (See Avoid return in constructors #2041 )

The purpose of that is to make the full migration the less risky possible by doing everything possible in the v5 branch.

jdeniau force-pushed the init-typescript-in-v5 branch from 61a908a to 6e58ee4 Compare February 22, 2025 20:54
jdeniau marked this pull request as ready for review February 22, 2025 21:06
jdeniau force-pushed the init-typescript-in-v5 branch from bd0509e to be4a9f1 Compare February 22, 2025 22:18
jdeniau force-pushed the init-typescript-in-v5 branch from 6555050 to a6b5146 Compare February 23, 2025 00:30
jdeniau merged commit 51ce099 into main Feb 23, 2025
jdeniau deleted the init-typescript-in-v5 branch February 23, 2025 20:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL