FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add group filters to list by j178 · Pull Request #2152 · j178/prek · GitHub

Repository navigation

Add group filters to list - #2152

Merged
j178 merged 1 commit into
masterfrom
list-groups
Jun 5, 2026
Merged

j178 merged 1 commit into
masterfrom
list-groups

Conversation

j178 commented Jun 4, 2026

Copy link
Copy Markdown
Owner

Adds --group and --no-group to prek list.

Copilot AI review requested due to automatic review settings June 4, 2026 12:27
j178 added the enhancement New feature or request label Jun 4, 2026

codecov Bot commented Jun 4, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.59%. Comparing base (daead87) to head (348837c).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2152   +/-   ##
=======================================
  Coverage   92.58%   92.59%           
=======================================
  Files         122      122           
  Lines       26192    26196    +4     
=======================================
+ Hits        24251    24255    +4     
  Misses       1941     1941           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Pull request overview

This PR extends prek list to support the same hook group filtering capabilities already available in prek run, by introducing --group and --no-group selectors and wiring them through hook initialization and filtering.

Changes:

  • Add --group / --no-group CLI flags to prek list and plumb them into the cli::list entrypoint.
  • Apply group filtering both during hook listing and during pre-clone repo initialization (so excluded remote repos need not be cloned).
  • Add integration tests and update CLI reference docs to reflect the new options.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
docs/reference/cli.md Documents prek list --group/--no-group options.
crates/prek/tests/list.rs Adds coverage for group include/exclude behavior, unused selector warnings, validation errors, and “don’t clone excluded remotes”.
crates/prek/src/workspace.rs Generalizes HookInitFilters constructor to accept optional selectors and group filters, enabling pre-clone filtering by group.
crates/prek/src/main.rs Passes groups / no_groups args into the cli::list call.
crates/prek/src/cli/run/run.rs Updates call site to the new HookInitFilters::new(...) constructor.
crates/prek/src/cli/mod.rs Adds groups / no_groups fields to ListArgs for clap wiring.
crates/prek/src/cli/list.rs Parses group filters, applies them to hook output, and reports unused group selectors.
crates/prek/src/cli/install.rs Updates call site to the new HookInitFilters::new(...) constructor.

prek-ci-bot Bot commented Jun 4, 2026 •
edited
Loading

Copy link
Copy Markdown

📦 Cargo Bloat Comparison

Binary size change: +0.00% (26.3 MiB → 26.3 MiB)

Expand for cargo-bloat output

Head Branch Results

 File  .text     Size             Crate Name
 1.2%   2.6% 332.0KiB        aws_lc_sys aws_lc_0_41_0_aes_gcm_encrypt_avx512
 1.2%   2.6% 332.0KiB        aws_lc_sys aws_lc_0_41_0_aes_gcm_decrypt_avx512
 0.3%   0.7%  90.4KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.3%   0.7%  85.5KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.3%   0.5%  69.9KiB              prek prek::languages::<impl prek::config::Language>::install::{{closure}}
 0.2%   0.5%  65.1KiB             prek? <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
 0.2%   0.4%  49.5KiB              prek prek::run::{{closure}}
 0.2%   0.4%  49.4KiB annotate_snippets annotate_snippets::renderer::render::render
 0.2%   0.3%  44.0KiB              prek prek::cli::run::run::run::{{closure}}
 0.1%   0.2%  31.8KiB             prek? <prek::cli::RunOptions as clap_builder::derive::Args>::augment_args
 0.1%   0.2%  30.4KiB             prek? <prek::config::_::<impl serde_core::de::Deserialize for prek::config::Config>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map
 0.1%   0.2%  30.2KiB               std core::ptr::drop_in_place<prek::languages::<impl prek::config::Language>::install::{{closure}}>
 0.1%   0.2%  28.1KiB      serde_saphyr granit_parser::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  28.0KiB        aws_lc_sys aws_lc_0_41_0_edwards25519_scalarmuldouble_alt
 0.1%   0.2%  27.5KiB        aws_lc_sys aws_lc_0_41_0_edwards25519_scalarmuldouble
 0.1%   0.2%  26.1KiB              prek prek::cli::try_repo::try_repo::{{closure}}
 0.1%   0.2%  23.0KiB      serde_saphyr granit_parser::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  22.3KiB              prek prek::hooks::meta_hooks::MetaHooks::run::{{closure}}
 0.1%   0.2%  22.3KiB         [Unknown] Lp384_montjscalarmul_alt_p384_montjadd
 0.1%   0.2%  21.9KiB     serde_saphyr? <serde_saphyr::de::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map
41.7%  86.3%  10.9MiB                   And 24101 smaller methods. Use -n N to show more.
48.3% 100.0%  12.7MiB                   .text section size, the file size is 26.3MiB

Base Branch Results

 File  .text     Size             Crate Name
 1.2%   2.6% 332.0KiB        aws_lc_sys aws_lc_0_41_0_aes_gcm_encrypt_avx512
 1.2%   2.6% 332.0KiB        aws_lc_sys aws_lc_0_41_0_aes_gcm_decrypt_avx512
 0.3%   0.7%  90.4KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.3%   0.7%  85.3KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.3%   0.5%  69.9KiB              prek prek::languages::<impl prek::config::Language>::install::{{closure}}
 0.2%   0.5%  61.9KiB             prek? <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
 0.2%   0.4%  49.4KiB annotate_snippets annotate_snippets::renderer::render::render
 0.2%   0.4%  48.5KiB              prek prek::run::{{closure}}
 0.2%   0.3%  44.6KiB              prek prek::cli::run::run::run::{{closure}}
 0.1%   0.2%  31.1KiB             prek? <prek::cli::RunOptions as clap_builder::derive::Args>::augment_args
 0.1%   0.2%  30.4KiB             prek? <prek::config::_::<impl serde_core::de::Deserialize for prek::config::Config>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map
 0.1%   0.2%  30.2KiB               std core::ptr::drop_in_place<prek::languages::<impl prek::config::Language>::install::{{closure}}>
 0.1%   0.2%  28.1KiB      serde_saphyr granit_parser::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  28.0KiB        aws_lc_sys aws_lc_0_41_0_edwards25519_scalarmuldouble_alt
 0.1%   0.2%  27.5KiB        aws_lc_sys aws_lc_0_41_0_edwards25519_scalarmuldouble
 0.1%   0.2%  26.1KiB              prek prek::cli::try_repo::try_repo::{{closure}}
 0.1%   0.2%  23.0KiB      serde_saphyr granit_parser::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  22.7KiB              prek prek::hooks::meta_hooks::MetaHooks::run::{{closure}}
 0.1%   0.2%  22.3KiB         [Unknown] Lp384_montjscalarmul_alt_p384_montjadd
 0.1%   0.2%  21.9KiB     serde_saphyr? <serde_saphyr::de::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map
41.7%  86.4%  11.0MiB                   And 24132 smaller methods. Use -n N to show more.
48.3% 100.0%  12.7MiB                   .text section size, the file size is 26.3MiB

prek-ci-bot Bot commented Jun 4, 2026 •
edited
Loading

Copy link
Copy Markdown

⚡️ Hyperfine Benchmarks

Summary: 0 regressions, 1 improvements above the 10% threshold.

Environment
  • OS: Linux 6.17.0-1015-azure
  • CPU: 4 cores
  • prek version: prek 0.4.4+4 (fb54f61 2026-06-05)
  • Rust version: rustc 1.96.0 (ac68faa20 2026-05-25)
  • Hyperfine version: hyperfine 1.20.0
CLI Commands

Benchmarking basic commands in the main repo:

prek --version

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base --version 2.4 ± 0.1 2.2 2.5 1.02 ± 0.04
prek-head --version 2.3 ± 0.1 2.2 2.6 1.00

prek list

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base list 9.4 ± 0.2 9.1 10.6 1.00 ± 0.03
prek-head list 9.4 ± 0.2 9.1 10.0 1.00

prek validate-config .pre-commit-config.yaml

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base validate-config .pre-commit-config.yaml 3.2 ± 0.0 3.1 3.4 1.01 ± 0.03
prek-head validate-config .pre-commit-config.yaml 3.2 ± 0.1 3.0 3.5 1.00

prek sample-config

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base sample-config 2.6 ± 0.0 2.5 2.7 1.00
prek-head sample-config 2.6 ± 0.0 2.6 2.7 1.01 ± 0.03
Cold vs Warm Runs

Comparing first run (cold) vs subsequent runs (warm cache):

prek run --all-files (cold - no cache)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run --all-files 80.9 ± 3.2 75.3 84.4 1.02 ± 0.06
prek-head run --all-files 79.6 ± 3.4 74.6 84.8 1.00

prek run --all-files (warm - with cache)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run --all-files 78.0 ± 3.4 73.6 85.0 1.00
prek-head run --all-files 80.7 ± 2.7 75.4 84.8 1.03 ± 0.06
Full Hook Suite

Running the builtin hook suite on the benchmark workspace:

prek run --all-files (full builtin hook suite)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run --all-files 79.6 ± 3.4 73.9 88.5 1.01 ± 0.06
prek-head run --all-files 79.2 ± 3.4 72.9 86.3 1.00
Individual Hook Performance

Benchmarking each hook individually on the test repo:

prek run trailing-whitespace --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run trailing-whitespace --all-files 21.2 ± 0.6 20.4 22.5 1.01 ± 0.03
prek-head run trailing-whitespace --all-files 21.0 ± 0.4 20.0 22.0 1.00

prek run end-of-file-fixer --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run end-of-file-fixer --all-files 27.8 ± 2.1 24.6 31.1 1.00
prek-head run end-of-file-fixer --all-files 27.8 ± 2.7 24.6 33.3 1.00 ± 0.12

prek run check-json --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run check-json --all-files 8.3 ± 0.2 7.8 8.7 1.00
prek-head run check-json --all-files 8.3 ± 0.2 7.9 8.9 1.00 ± 0.04

prek run check-yaml --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run check-yaml --all-files 8.4 ± 1.6 7.8 16.8 1.05 ± 0.20
prek-head run check-yaml --all-files 8.0 ± 0.2 7.8 8.4 1.00

prek run check-toml --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run check-toml --all-files 8.2 ± 0.3 7.8 8.8 1.01 ± 0.05
prek-head run check-toml --all-files 8.2 ± 0.3 7.6 8.8 1.00

prek run check-xml --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run check-xml --all-files 8.2 ± 0.3 7.7 8.9 1.01 ± 0.04
prek-head run check-xml --all-files 8.2 ± 0.2 7.7 8.6 1.00

prek run detect-private-key --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run detect-private-key --all-files 14.1 ± 1.4 12.3 18.0 1.03 ± 0.14
prek-head run detect-private-key --all-files 13.7 ± 1.2 12.2 17.0 1.00

prek run fix-byte-order-marker --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run fix-byte-order-marker --all-files 22.5 ± 1.4 20.4 25.0 1.00
prek-head run fix-byte-order-marker --all-files 23.0 ± 1.3 20.3 25.1 1.02 ± 0.09
Installation Performance

Benchmarking hook installation (fast path hooks skip Python setup):

prek install-hooks (cold - no cache)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base install-hooks 4.8 ± 0.1 4.7 4.8 1.01 ± 0.02
prek-head install-hooks 4.7 ± 0.1 4.7 4.8 1.00

prek install-hooks (warm - with cache)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base install-hooks 4.7 ± 0.1 4.6 4.9 1.00
prek-head install-hooks 4.8 ± 0.1 4.6 4.9 1.00 ± 0.03
File Filtering/Scoping Performance

Testing different file selection modes:

prek run (staged files only)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run 39.5 ± 0.8 38.5 41.4 1.00
prek-head run 41.1 ± 1.7 39.0 46.0 1.04 ± 0.05

prek run --files '*.json' (specific file type)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run --files '*.json' 31.1 ± 68.6 8.6 300.6 3.62 ± 7.96
prek-head run --files '*.json' 8.6 ± 0.1 8.5 8.7 1.00

✅ Performance improvement for prek run --files '*.json' (specific file type): 72.3500% faster

Workspace Discovery & Initialization

Benchmarking hook discovery and initialization overhead:

prek run --dry-run --all-files (measures init overhead)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run --dry-run --all-files 7.5 ± 0.1 7.3 7.7 1.02 ± 0.02
prek-head run --dry-run --all-files 7.3 ± 0.1 7.2 7.7 1.00
Meta Hooks Performance

Benchmarking meta hooks separately:

prek run check-hooks-apply --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run check-hooks-apply --all-files 12.8 ± 0.1 12.7 13.0 1.00
prek-head run check-hooks-apply --all-files 12.9 ± 0.1 12.7 13.1 1.00 ± 0.01

prek run check-useless-excludes --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run check-useless-excludes --all-files 11.9 ± 0.5 11.3 12.8 1.04 ± 0.05
prek-head run check-useless-excludes --all-files 11.5 ± 0.1 11.3 11.7 1.00

prek run identity --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run identity --all-files 10.9 ± 0.1 10.7 11.0 1.00
prek-head run identity --all-files 10.9 ± 0.1 10.7 11.0 1.00 ± 0.01

Base automatically changed from skip-clone to master June 5, 2026 05:16
j178 merged commit fb2d47f into master Jun 5, 2026
34 checks passed
j178 deleted the list-groups branch June 5, 2026 08:34
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Jun 17, 2026
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [prek](https://github.com/j178/prek) | patch | `0.4.4` → `0.4.5` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>j178/prek (prek)</summary>

### [`v0.4.5`](https://github.com/j178/prek/blob/HEAD/CHANGELOG.md#045)

[Compare Source](j178/prek@v0.4.4...v0.4.5)

Released on 2026-06-15.

##### ✨Highlights

0.4.5 completes `prek`'s pre-commit language coverage. With R, Conda, Perl,
and coursier now supported, `prek` supports every language available in
pre-commit, plus `prek`-only modern languages such as Bun and Deno.

This is full feature parity with pre-commit. The last major compatibility gap
is closed, and `prek` is now on the path to 1.0.

##### 💚 Sponsorship

If `prek` saves time for you or your team, please consider sponsoring the
project on [GitHub Sponsors](https://github.com/sponsors/j178). It helps keep
new features, performance work, and maintenance moving.

##### Enhancements

- Add `Perl` language support ([#&#8203;2201](j178/prek#2201))
- Add `R` language support ([#&#8203;2206](j178/prek#2206))
- Add `Conda` language support ([#&#8203;2203](j178/prek#2203))
- Add `coursier` language support ([#&#8203;2194](j178/prek#2194))
- Add group filters to list ([#&#8203;2152](j178/prek#2152))
- Remove legacy repo path support ([#&#8203;2150](j178/prek#2150))
- Skip cloning fully filtered remote repos ([#&#8203;2151](j178/prek#2151))

##### Performance

- Avoid building JSON trees in syntax hooks ([#&#8203;2156](j178/prek#2156))
- Scan mixed line endings without line vector ([#&#8203;2160](j178/prek#2160))
- Skip file scan for always-run no-filename hooks ([#&#8203;2155](j178/prek#2155))
- Use fixed buffer for EOF scan ([#&#8203;2163](j178/prek#2163))
- Use fixed buffer for private key scan ([#&#8203;2164](j178/prek#2164))

##### Bug fixes

- Fix pretty-format-json CRLF handling ([#&#8203;2210](j178/prek#2210))
- Handle missing blobs in diff snapshots ([#&#8203;2211](j178/prek#2211))
- Ignore coursier channel from working repo ([#&#8203;2202](j178/prek#2202))

##### Contributors

- [@&#8203;j178](https://github.com/j178)

</details>

---

### Configuration

📅 **Schedule**: (UTC)

- Branch creation
  - At any time (no schedule defined)
- Automerge
  - At any time (no schedule defined)

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4yMTguMCIsInVwZGF0ZWRJblZlciI6IjQzLjIxOC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiLCJhdXRvbWF0aW9uOmJvdC1hdXRob3JlZCIsImRlcGVuZGVuY3ktdHlwZTo6cGF0Y2giXX0=-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL