Skip file scan for always-run no-filename hooks by j178 · Pull Request #2155 · j178/prek · GitHub

No description provided.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.59%. Comparing base (671d33b) to head (70f126a).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2155      +/-   ##
==========================================
- Coverage   92.63%   92.59%   -0.05%     
==========================================
  Files         122      122              
  Lines       26179    26180       +1     
==========================================
- Hits        24251    24241      -10     
- Misses       1928     1939      +11

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

📦 Cargo Bloat Comparison

Binary size change: +0.00% (26.3 MiB → 26.3 MiB)

Expand for cargo-bloat output

Head Branch Results

 File  .text     Size             Crate Name
 1.2%   2.6% 332.0KiB        aws_lc_sys aws_lc_0_41_0_aes_gcm_encrypt_avx512
 1.2%   2.6% 332.0KiB        aws_lc_sys aws_lc_0_41_0_aes_gcm_decrypt_avx512
 0.3%   0.7%  86.8KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.3%   0.7%  85.5KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.3%   0.5%  69.9KiB              prek prek::languages::<impl prek::config::Language>::install::{{closure}}
 0.2%   0.5%  65.1KiB             prek? <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
 0.2%   0.4%  49.5KiB              prek prek::run::{{closure}}
 0.2%   0.4%  49.4KiB annotate_snippets annotate_snippets::renderer::render::render
 0.2%   0.3%  44.1KiB              prek prek::cli::run::run::run::{{closure}}
 0.1%   0.2%  31.8KiB             prek? <prek::cli::RunOptions as clap_builder::derive::Args>::augment_args
 0.1%   0.2%  30.4KiB             prek? <prek::config::_::<impl serde_core::de::Deserialize for prek::config::Config>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map
 0.1%   0.2%  30.2KiB               std core::ptr::drop_in_place<prek::languages::<impl prek::config::Language>::install::{{closure}}>
 0.1%   0.2%  28.1KiB      serde_saphyr granit_parser::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  28.0KiB        aws_lc_sys aws_lc_0_41_0_edwards25519_scalarmuldouble_alt
 0.1%   0.2%  27.5KiB        aws_lc_sys aws_lc_0_41_0_edwards25519_scalarmuldouble
 0.1%   0.2%  26.1KiB              prek prek::cli::try_repo::try_repo::{{closure}}
 0.1%   0.2%  23.0KiB      serde_saphyr granit_parser::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  22.3KiB         [Unknown] Lp384_montjscalarmul_alt_p384_montjadd
 0.1%   0.2%  21.9KiB     serde_saphyr? <serde_saphyr::de::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map
 0.1%   0.2%  21.5KiB      clap_builder clap_builder::parser::parser::Parser::get_matches_with
41.7%  86.3%  10.9MiB                   And 24108 smaller methods. Use -n N to show more.
48.3% 100.0%  12.7MiB                   .text section size, the file size is 26.3MiB

Base Branch Results

 File  .text     Size             Crate Name
 1.2%   2.6% 332.0KiB        aws_lc_sys aws_lc_0_41_0_aes_gcm_encrypt_avx512
 1.2%   2.6% 332.0KiB        aws_lc_sys aws_lc_0_41_0_aes_gcm_decrypt_avx512
 0.3%   0.7%  86.8KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.3%   0.7%  85.5KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.3%   0.5%  69.9KiB              prek prek::languages::<impl prek::config::Language>::install::{{closure}}
 0.2%   0.5%  65.1KiB             prek? <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
 0.2%   0.4%  49.5KiB              prek prek::run::{{closure}}
 0.2%   0.4%  49.4KiB annotate_snippets annotate_snippets::renderer::render::render
 0.2%   0.3%  44.1KiB              prek prek::cli::run::run::run::{{closure}}
 0.1%   0.2%  31.8KiB             prek? <prek::cli::RunOptions as clap_builder::derive::Args>::augment_args
 0.1%   0.2%  30.4KiB             prek? <prek::config::_::<impl serde_core::de::Deserialize for prek::config::Config>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map
 0.1%   0.2%  30.2KiB               std core::ptr::drop_in_place<prek::languages::<impl prek::config::Language>::install::{{closure}}>
 0.1%   0.2%  28.1KiB      serde_saphyr granit_parser::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  28.0KiB        aws_lc_sys aws_lc_0_41_0_edwards25519_scalarmuldouble_alt
 0.1%   0.2%  27.5KiB        aws_lc_sys aws_lc_0_41_0_edwards25519_scalarmuldouble
 0.1%   0.2%  26.1KiB              prek prek::cli::try_repo::try_repo::{{closure}}
 0.1%   0.2%  23.0KiB      serde_saphyr granit_parser::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  22.3KiB         [Unknown] Lp384_montjscalarmul_alt_p384_montjadd
 0.1%   0.2%  21.9KiB     serde_saphyr? <serde_saphyr::de::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map
 0.1%   0.2%  21.5KiB      clap_builder clap_builder::parser::parser::Parser::get_matches_with
41.7%  86.3%  10.9MiB                   And 24108 smaller methods. Use -n N to show more.
48.3% 100.0%  12.7MiB                   .text section size, the file size is 26.3MiB

⚡️ Hyperfine Benchmarks

Summary: 0 regressions, 0 improvements above the 10% threshold.

Environment

OS: Linux 6.17.0-1015-azure
CPU: 4 cores
prek version: prek 0.4.4+6 (037503d 2026-06-06)
Rust version: rustc 1.96.0 (ac68faa20 2026-05-25)
Hyperfine version: hyperfine 1.20.0

CLI Commands

Benchmarking basic commands in the main repo:

prek --version

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base --version	2.2 ± 0.1	2.1	2.5	1.03 ± 0.07
prek-head --version	2.2 ± 0.1	2.0	2.7	1.00

prek list

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base list	8.8 ± 0.8	8.5	17.1	1.04 ± 0.10
prek-head list	8.5 ± 0.1	8.3	8.9	1.00

prek validate-config .pre-commit-config.yaml

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base validate-config .pre-commit-config.yaml	3.1 ± 0.0	3.0	3.2	1.08 ± 0.02
prek-head validate-config .pre-commit-config.yaml	2.8 ± 0.0	2.7	3.0	1.00

prek sample-config

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base sample-config	2.5 ± 0.0	2.4	2.6	1.07 ± 0.03
prek-head sample-config	2.4 ± 0.0	2.3	2.5	1.00

Cold vs Warm Runs

Comparing first run (cold) vs subsequent runs (warm cache):

prek run --all-files (cold - no cache)

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run --all-files	75.2 ± 2.0	71.0	78.1	1.04 ± 0.05
prek-head run --all-files	72.3 ± 2.7	68.7	76.9	1.00

prek run --all-files (warm - with cache)

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run --all-files	75.0 ± 3.5	69.9	83.9	1.02 ± 0.07
prek-head run --all-files	73.9 ± 3.5	68.5	80.7	1.00

Full Hook Suite

Running the builtin hook suite on the benchmark workspace:

prek run --all-files (full builtin hook suite)

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run --all-files	76.8 ± 5.1	70.9	93.4	1.04 ± 0.08
prek-head run --all-files	73.9 ± 3.3	68.6	81.0	1.00

Individual Hook Performance

Benchmarking each hook individually on the test repo:

prek run trailing-whitespace --all-files

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run trailing-whitespace --all-files	19.3 ± 0.5	18.5	20.3	1.01 ± 0.04
prek-head run trailing-whitespace --all-files	19.0 ± 0.5	18.4	20.5	1.00

prek run end-of-file-fixer --all-files

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run end-of-file-fixer --all-files	24.5 ± 1.6	22.6	28.5	1.00
prek-head run end-of-file-fixer --all-files	24.8 ± 1.8	22.3	27.8	1.01 ± 0.10

prek run check-json --all-files

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run check-json --all-files	7.6 ± 0.4	7.0	8.8	1.05 ± 0.06
prek-head run check-json --all-files	7.2 ± 0.3	6.7	8.0	1.00

prek run check-yaml --all-files

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run check-yaml --all-files	7.3 ± 0.2	7.1	7.7	1.04 ± 0.03
prek-head run check-yaml --all-files	7.1 ± 0.1	6.9	7.5	1.00

prek run check-toml --all-files

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run check-toml --all-files	7.5 ± 0.4	7.1	8.5	1.04 ± 0.07
prek-head run check-toml --all-files	7.2 ± 0.3	6.7	8.1	1.00

prek run check-xml --all-files

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run check-xml --all-files	7.5 ± 0.2	7.0	7.9	1.04 ± 0.05
prek-head run check-xml --all-files	7.2 ± 0.3	6.6	7.9	1.00

prek run detect-private-key --all-files

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run detect-private-key --all-files	13.1 ± 1.2	11.4	15.1	1.00
prek-head run detect-private-key --all-files	13.1 ± 1.1	11.0	15.4	1.00 ± 0.13

prek run fix-byte-order-marker --all-files

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run fix-byte-order-marker --all-files	21.6 ± 1.5	18.7	23.9	1.01 ± 0.10
prek-head run fix-byte-order-marker --all-files	21.4 ± 1.6	18.3	23.8	1.00

Installation Performance

Benchmarking hook installation (fast path hooks skip Python setup):

prek install-hooks (cold - no cache)

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base install-hooks	4.6 ± 0.1	4.4	4.7	1.09 ± 0.03
prek-head install-hooks	4.2 ± 0.0	4.1	4.3	1.00

prek install-hooks (warm - with cache)

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base install-hooks	4.5 ± 0.0	4.4	4.5	1.05 ± 0.02
prek-head install-hooks	4.2 ± 0.1	4.2	4.3	1.00

File Filtering/Scoping Performance

Testing different file selection modes:

prek run (staged files only)

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run	36.7 ± 1.1	35.4	39.0	1.01 ± 0.04
prek-head run	36.5 ± 1.1	35.1	38.4	1.00

prek run --files '*.json' (specific file type)

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run --files '*.json'	7.8 ± 0.1	7.7	7.9	1.02 ± 0.02
prek-head run --files '*.json'	7.6 ± 0.1	7.5	8.0	1.00

Workspace Discovery & Initialization

Benchmarking hook discovery and initialization overhead:

prek run --dry-run --all-files (measures init overhead)

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run --dry-run --all-files	6.8 ± 0.1	6.7	6.9	1.04 ± 0.02
prek-head run --dry-run --all-files	6.5 ± 0.1	6.4	6.7	1.00

Meta Hooks Performance

Benchmarking meta hooks separately:

prek run check-hooks-apply --all-files

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run check-hooks-apply --all-files	11.7 ± 0.1	11.6	11.8	1.04 ± 0.07
prek-head run check-hooks-apply --all-files	11.2 ± 0.7	10.0	12.1	1.00

prek run check-useless-excludes --all-files

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run check-useless-excludes --all-files	10.5 ± 0.2	10.3	11.1	1.05 ± 0.02
prek-head run check-useless-excludes --all-files	10.1 ± 0.1	9.9	10.3	1.00

prek run identity --all-files

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run identity --all-files	10.2 ± 0.5	9.7	11.1	1.05 ± 0.07
prek-head run identity --all-files	9.6 ± 0.4	9.3	10.6	1.00

Pull request overview

This PR optimizes hook execution in prek’s run command by avoiding an unnecessary file-matching scan for hooks that are configured to always run and do not accept filename arguments.

Changes:

Short-circuit ProjectHookInput::run_input_for_hook for always_run hooks with pass_filenames: none, returning a no-filenames run input without scanning for matching files.

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [prek](https://github.com/j178/prek) | patch | `0.4.4` → `0.4.5` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>j178/prek (prek)</summary> ### [`v0.4.5`](https://github.com/j178/prek/blob/HEAD/CHANGELOG.md#045) [Compare Source](j178/prek@v0.4.4...v0.4.5) Released on 2026-06-15. ##### ✨Highlights 0.4.5 completes `prek`'s pre-commit language coverage. With R, Conda, Perl, and coursier now supported, `prek` supports every language available in pre-commit, plus `prek`-only modern languages such as Bun and Deno. This is full feature parity with pre-commit. The last major compatibility gap is closed, and `prek` is now on the path to 1.0. ##### 💚 Sponsorship If `prek` saves time for you or your team, please consider sponsoring the project on [GitHub Sponsors](https://github.com/sponsors/j178). It helps keep new features, performance work, and maintenance moving. ##### Enhancements - Add `Perl` language support ([#2201](j178/prek#2201)) - Add `R` language support ([#2206](j178/prek#2206)) - Add `Conda` language support ([#2203](j178/prek#2203)) - Add `coursier` language support ([#2194](j178/prek#2194)) - Add group filters to list ([#2152](j178/prek#2152)) - Remove legacy repo path support ([#2150](j178/prek#2150)) - Skip cloning fully filtered remote repos ([#2151](j178/prek#2151)) ##### Performance - Avoid building JSON trees in syntax hooks ([#2156](j178/prek#2156)) - Scan mixed line endings without line vector ([#2160](j178/prek#2160)) - Skip file scan for always-run no-filename hooks ([#2155](j178/prek#2155)) - Use fixed buffer for EOF scan ([#2163](j178/prek#2163)) - Use fixed buffer for private key scan ([#2164](j178/prek#2164)) ##### Bug fixes - Fix pretty-format-json CRLF handling ([#2210](j178/prek#2210)) - Handle missing blobs in diff snapshots ([#2211](j178/prek#2211)) - Ignore coursier channel from working repo ([#2202](j178/prek#2202)) ##### Contributors - [@j178](https://github.com/j178) </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate).

j178 force-pushed the codex/optimize-prek-run-skips branch from 1372ca7 to 104cfe2 Compare June 6, 2026 06:22

j178 changed the title Improve skipped hook scheduling Skip file scan for always-run no-filename hooks Jun 6, 2026

Improve skipped hook scheduling

70f126a

j178 force-pushed the codex/optimize-prek-run-skips branch from 104cfe2 to 70f126a Compare June 6, 2026 06:25

j178 added the performance Performance improvements label Jun 6, 2026

j178 marked this pull request as ready for review June 6, 2026 06:30

Copilot AI review requested due to automatic review settings June 6, 2026 06:30

Copilot started reviewing on behalf of j178 June 6, 2026 06:30

View session

Copilot AI reviewed Jun 6, 2026

View reviewed changes

Comment thread crates/prek/src/cli/run/run.rs Resolved

j178 merged commit d30253b into master Jun 6, 2026
35 checks passed

j178 deleted the codex/optimize-prek-run-skips branch June 6, 2026 06:48

BrewTestBot mentioned this pull request Jun 15, 2026

prek 0.4.5 Homebrew/homebrew-core#288054

Merged

Skip file scan for always-run no-filename hooks by j178 · Pull Request #2155 · j178/prek · GitHub

Repository navigation

Skip file scan for always-run no-filename hooks - #2155

Skip file scan for always-run no-filename hooks#2155
j178 merged 1 commit into
masterfrom
codex/optimize-prek-run-skips

j178 commented Jun 6, 2026 •
edited
Loading

Uh oh!

Uh oh!

codecov Bot commented Jun 6, 2026 •
edited
Loading

Uh oh!

Uh oh!

prek-ci-bot Bot commented Jun 6, 2026 •
edited
Loading

Uh oh!

Uh oh!

prek-ci-bot Bot commented Jun 6, 2026 •
edited
Loading

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Skip file scan for always-run no-filename hooks by j178 · Pull Request #2155 · j178/prek · GitHub

Repository navigation

Skip file scan for always-run no-filename hooks - #2155

Skip file scan for always-run no-filename hooks#2155j178 merged 1 commit intomasterj178/prek:masterfrom codex/optimize-prek-run-skipsj178/prek:codex/optimize-prek-run-skipsCopy head branch name to clipboard

Conversation

j178 commented Jun 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Jun 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

prek-ci-bot Bot commented Jun 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Cargo Bloat Comparison

Head Branch Results

Base Branch Results

Uh oh!

prek-ci-bot Bot commented Jun 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚡️ Hyperfine Benchmarks

prek --version

prek list

prek validate-config .pre-commit-config.yaml

prek sample-config

prek run --all-files (cold - no cache)

prek run --all-files (warm - with cache)

prek run --all-files (full builtin hook suite)

prek run trailing-whitespace --all-files

prek run end-of-file-fixer --all-files

prek run check-json --all-files

prek run check-yaml --all-files

prek run check-toml --all-files

prek run check-xml --all-files

prek run detect-private-key --all-files

prek run fix-byte-order-marker --all-files

prek install-hooks (cold - no cache)

prek install-hooks (warm - with cache)

prek run (staged files only)

prek run --files '*.json' (specific file type)

prek run --dry-run --all-files (measures init overhead)

prek run check-hooks-apply --all-files

prek run check-useless-excludes --all-files

prek run identity --all-files

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Skip file scan for always-run no-filename hooks#2155
j178 merged 1 commit into
masterfrom
codex/optimize-prek-run-skips

j178 commented Jun 6, 2026 •
edited
Loading

codecov Bot commented Jun 6, 2026 •
edited
Loading

prek-ci-bot Bot commented Jun 6, 2026 •
edited
Loading

prek-ci-bot Bot commented Jun 6, 2026 •
edited
Loading