Allow no-arg and chained Proc#refined and copy the block lazily - #9555
Open
shugo wants to merge 2 commits into
Open
Allow no-arg and chained Proc#refined and copy the block lazily#9555shugo wants to merge 2 commits into
shugo wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@shugo Let me know if you need assistance here. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
Thank you! [Feature #22213] has been accepted by Matz, so I'd like to squash the commits in this branch and make this pull request ready for review. |
Sorry, something went wrong.
Proc#hash was missing, so procs that are eql? (e.g. a proc and its dup) hashed differently. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Since prc.refined(*ms).refined(*ns) is behaviorally equivalent to prc.refined(*ms, *ns), a chained call re-clones from the original closure with the merged module list and the memoized copy is shared by these behaviorally equivalent Procs. The copy of the block's IR is deferred until the first call, so a Proc that is never called is no longer copied at all. [Feature #22213] Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
shugo
force-pushed
the
feature/composable-proc-refined
branch
from
80b9177 to
0b9fad0
Compare
August 9, 2026 10:02
shugo
marked this pull request as ready for review
August 9, 2026 10:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since prc.refined(*ms).refined(*ns) is behaviorally equivalent to prc.refined(*ms, *ns), a chained call re-clones from the original closure with the merged module list and the memoized copy is shared by these behaviorally equivalent Procs. The copy of the block's IR is deferred until the first call, so a Proc that is never called is no longer copied at all.
(https://bugs.ruby-lang.org/issues/22213, ruby/ruby d4a6282429)