This repository was archived by the owner on Jan 13, 2024. It is now read-only.
change GetFilePath param from int to IntPtr - #106
Open
molsonkiko wants to merge 3 commits into
Open
molsonkiko wants to merge 3 commits into
molsonkiko wants to merge 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Previously the GetFilePath method of NotepadPPGateway was unusable in 64-bit Notepad++ because it accepted an int parameter, but the buffer id (the IdFrom parameter of the NPPN_FILEBEFORECLOSE notification) could be 64-bit. Also added a new plugin command to Demo.cs illustrating how tracking the NPPN_FILEBEFORECLOSE notification allows the plugin to keep a list of all the filenames that were closed this session.
kbilsted
approved these changes
May 19, 2023
Copy link
Copy Markdown
Owner
|
merge conflict |
Sorry, something went wrong.
fix bug introduced in merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewerAt least 1 approving review is required to merge this pull request.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the GetFilePath method of NotepadPPGateway was unusable in 64-bit Notepad++ because it accepted an int parameter, but the buffer id (the IdFrom parameter of the NPPN_FILEBEFORECLOSE notification) could be 64-bit.
Also added a new plugin command to Demo.cs illustrating how tracking the NPPN_FILEBEFORECLOSE notification allows the plugin to keep a list of all the filenames that were closed this session.