FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Make StartConfig listener creation context-aware by EricGusmao · Pull Request #2936 · labstack/echo · GitHub

/ echo Public

Make StartConfig listener creation context-aware - #2936

Merged
aldas merged 1 commit into
labstack:masterfrom
EricGusmao:use-listenconfig-for-startconfig
Apr 4, 2026
ConversationCommits (1)ChecksFiles changed
Merged

Make StartConfig listener creation context-aware#2936
aldas merged 1 commit into
labstack:masterfrom
EricGusmao:use-listenconfig-for-startconfig

Conversation

EricGusmao commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Create listeners with net.ListenConfig so StartConfig respects the provided context during listener setup
  • Keep the existing serving behavior by defaulting ListenerNetwork to tcp and wrapping TLS listeners with
    tls.NewListener
  • simplify the listener creation path by using the same flow for TLS and non-TLS listeners

Benefit

StartConfig.Start and StartConfig.StartTLS already accept a context, but listener creation previously used net.Listen
and tls.Listen, which do not use that context. This change makes listener setup context-aware without changing how the
server behaves after the listener is created.

codecov Bot commented Apr 4, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.07%. Comparing base (22e4b71) to head (2da598d).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2936      +/-   ##
==========================================
- Coverage   93.07%   93.07%   -0.01%     
==========================================
  Files          43       43              
  Lines        4506     4503       -3     
==========================================
- Hits         4194     4191       -3     
  Misses        195      195              
  Partials      117      117

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

aldas approved these changes Apr 4, 2026
View reviewed changes

aldas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

aldas merged commit 607f385 into labstack:master Apr 4, 2026
10 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

aldas aldas approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL