FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(lint): resolve staticcheck issues and improve code quality by itsllyaz · Pull Request #2941 · labstack/echo · GitHub

/ echo Public

fix(lint): resolve staticcheck issues and improve code quality - #2941

Merged
aldas merged 6 commits into
labstack:masterfrom
itsllyaz:fix/lint-staticcheck
Apr 7, 2026
ConversationCommits (6)ChecksFiles changed
Merged

fix(lint): resolve staticcheck issues and improve code quality#2941
aldas merged 6 commits into
labstack:masterfrom
itsllyaz:fix/lint-staticcheck

Conversation

itsllyaz commented Apr 6, 2026

Copy link
Copy Markdown
Contributor

This PR resolves several staticcheck lint issues, got the report from golangci-lint.

Changes

  • Applied De Morgan’s law to simplify boolean expressions
  • Replaced fmt.Sprintf with fmt.Fprintf to avoid unnecessary allocations
  • Removed redundant embedded field access
  • Improved overall code readability and idiomatic Go usage

Impact

  • No functional changes
  • Minor performance improvements
  • Cleaner and more maintainable code

Notes

All changes were verified with:

golangci-lint run

there is no remaining lint issues.

codecov Bot commented Apr 6, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.07%. Comparing base (22e4b71) to head (b1d350e).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2941      +/-   ##
==========================================
- Coverage   93.07%   93.07%   -0.01%     
==========================================
  Files          43       43              
  Lines        4506     4503       -3     
==========================================
- Hits         4194     4191       -3     
  Misses        195      195              
  Partials      117      117

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

aldas requested changes Apr 6, 2026
View reviewed changes

aldas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

please run go fmt

Comment thread route.go Outdated
aldas approved these changes Apr 7, 2026
View reviewed changes

aldas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

aldas merged commit 0143b9d into labstack:master Apr 7, 2026
10 checks passed

aldas commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

Thanks @itsllyaz

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

aldas aldas approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL