Context.Json should not unwrap response - #2964
Merged
aldas merged 1 commit intoMay 1, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…er middlewares can use their own "wrapping" Responses and see the status code.
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## master #2964 +/- ##
==========================================
+ Coverage 93.08% 93.18% +0.10%
==========================================
Files 43 43
Lines 4510 4507 -3
==========================================
+ Hits 4198 4200 +2
+ Misses 195 189 -6
- Partials 117 118 +1 ☔ View full report in Codecov by Sentry.
|
Sorry, something went wrong.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context.Json should not unwrap response and just wrap Response so other middlewares can use their own "wrapping" Responses and see the status code.
I found this during #2895 when to tried to create middleware that wraps existing response to own and status code setting did not work anymore with Context.JSON (always sends 200 to client).