fix(syncChannel): give child process time to exit before kill in close() - #64246
Open
Avisek Ray (biisal) wants to merge 2 commits into
Open
fix(syncChannel): give child process time to exit before kill in close()#64246Avisek Ray (biisal) wants to merge 2 commits into
Avisek Ray (biisal) wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Daniel Rosenwasser (DanielRosenwasser)
requested a balanced review from Copilot
September 11, 2026 17:30
Copilot started reviewing on behalf of
Daniel Rosenwasser (DanielRosenwasser)
September 11, 2026 17:31
View session
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The polling always blocks for the full delay, and the shutdown behavior lacks regression coverage.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details- Files reviewed: 1/1 changed files
- Comments generated: 2
- Review effort level: Balanced
Sorry, something went wrong.
Comment thread
packages/typescript/src/api/syncChannel.ts
Comment on lines
+262
to
+266
| for (let i = 0; i < 50 && this.child.exitCode === null && this.child.signalCode === null; i++) { | ||
| Atomics.wait(sleepBuf, 0, 0, 1); | ||
| } | ||
| if (this.child.exitCode === null && this.child.signalCode === null) { | ||
| this.child.kill(); |
Comment thread
packages/typescript/src/api/syncChannel.ts
Comment on lines
+262
to
+266
| for (let i = 0; i < 50 && this.child.exitCode === null && this.child.signalCode === null; i++) { | ||
| Atomics.wait(sleepBuf, 0, 0, 1); | ||
| } | ||
| if (this.child.exitCode === null && this.child.signalCode === null) { | ||
| this.child.kill(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #64242