fix(filesystem): tolerate quoted, spaced, and 8.3 Windows paths in config args (#447) - #4684
Open
adityachaudhary99 wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #447
Paths with spaces, surrounding quotes, a leading tilde, Git-Bash style /c/foo prefixes, or 8.3 short names could fail when configured as allowed directories.
Tests: extended path-utils suite + win32-gated startup spawn tests; green locally on Windows 11.
Note: submitted alongside #470; whichever merges second rebases cleanly (both touch the index.ts startup block).