fix: re-raise existing exception when available - #667
Merged
methane merged 2 commits intoApr 21, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Would it be easy to add a test case for this issue? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Ah yeah good point, let me have a look :) |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
I added a test case, but I don't think it's possible to easily cover/simulate something that would happen like in #666. But the tests do flex the PyErr_Occurred path. |
Sorry, something went wrong.
KowalskiThomas
deleted the
kowalski/fix-re-raise-existing-exception-when-available
branch
April 29, 2026 07:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR?
This PR addresses an issue I found while working on #666 and reported in the description there.
Looking at the usages of unpack_callback_uint32 (here for example, which calls into this) it seems like it checks for error values -2 and -3, but -1 will just raise ValueError("Unpack failed: error = %d" % (ret,)).
It believe it should just raise to raise the existing exception set by PyErr_SetString if it exists. This PR addresses that problem here and another place.