FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: translate RecursionError to StackError in fallback Unpacker.skip() by hdimer · Pull Request #727 · msgpack/msgpack-python · GitHub

/ msgpack-python Public

fix: translate RecursionError to StackError in fallback Unpacker.skip() #727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
methane merged 1 commit into from
Aug 17, 2026
+9 −1
Conversation 0 Commits 1 Checks 50 Files changed 2
Merged

fix: translate RecursionError to StackError in fallback Unpacker.skip() #727

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .py  (2) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
5 changes: 4 additions & 1 deletion msgpack/fallback.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -582,7 +582,10 @@ def __next__(self):
next = __next__

def skip(self):
self._unpack(EX_SKIP)
try:
self._unpack(EX_SKIP)
except RecursionError:
raise StackError
self._consume()

def unpack(self):
Expand Down
5 changes: 5 additions & 0 deletions test/test_except.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,11 @@ def test_invalidvalue():
with raises(StackError):
unpackb(b"\x91" * 3000) # nested fixarray(len=1)

with raises(StackError):
unpacker = Unpacker()
unpacker.feed(b"\x91" * 3000)
unpacker.skip()


def test_no_memory_leak_on_nested_invalid_tag() -> None:
"""Regression test: unpacking nested arrays containing an invalid tag must not leak objects."""
Expand Down
Back | FazBrowse Home | New Git URL