FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

typings: update 'types' binding by Renegade334 · Pull Request #59692 · nodejs/node · GitHub

/ node Public

typings: update 'types' binding - #59692

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
Renegade334:types-binding-typings
Sep 24, 2025
ConversationCommits (1)ChecksFiles changed
Merged

typings: update 'types' binding#59692
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
Renegade334:types-binding-typings

Conversation

Renegade334 commented Aug 31, 2025

Copy link
Copy Markdown
Member
  • Add missing methods:
    • isGeneratorObject
    • isProxy
    • isSharedArrayBuffer
    • isSymbolObject
  • Remove non-extant methods:
    • isTypedArray
  • Fix bad predicates:
    • isDate, isNativeError, isRegExp
      • These were previously declared to return the type itself, not a predicate.
  • Improvements to predicate types:
    • isArgumentsObject
      • TypeScript provides IArguments to describe the built-in arguments object.
    • isExternal
      • In TypeScript, object is the non-primitive object type. Object resolves to any value that is not null or undefined.

These definitions remain compatible with TS 3.9+, as before.

Also sorts the macro list in node_types.cc and matches the ordering in types.d.ts to the source, for ease of maintenance.

typings: update 'types' binding
d1468d6 
- Adds:
  - isGeneratorObject
  - isProxy
  - isSharedArrayBuffer
  - isSymbolObject
- Removes:
  - isTypedArray
- Fixes:
  - isDate
  - isNativeError
  - isRegExp
- Improves:
  - isArgumentsObject
  - isExternal
nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. typings labels Aug 31, 2025

codecov Bot commented Aug 31, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.91%. Comparing base (f36de72) to head (d1468d6).
⚠️ Report is 169 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #59692      +/-   ##
==========================================
+ Coverage   89.86%   89.91%   +0.05%     
==========================================
  Files         667      667              
  Lines      196792   196792              
  Branches    38632    38414     -218     
==========================================
+ Hits       176842   176945     +103     
+ Misses      12370    12266     -104     
- Partials     7580     7581       +1
Files with missing lines Coverage Δ
src/node_types.cc 94.87% <ø> (ø)

... and 39 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

daeyeon added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Sep 1, 2025
BridgeAR added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 14, 2025
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 14, 2025

nodejs-github-bot commented Sep 14, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69228/

nodejs-github-bot commented Sep 23, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69335/

addaleax added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 24, 2025
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 24, 2025
nodejs-github-bot merged commit e4e86ea into nodejs:main Sep 24, 2025
77 checks passed

nodejs-github-bot commented Sep 24, 2025

Copy link
Copy Markdown
Collaborator

Landed in e4e86ea

Renegade334 deleted the types-binding-typings branch September 24, 2025 17:21
targos pushed a commit that referenced this pull request Oct 6, 2025
typings: update 'types' binding
275c070 
- Adds:
  - isGeneratorObject
  - isProxy
  - isSharedArrayBuffer
  - isSymbolObject
- Removes:
  - isTypedArray
- Fixes:
  - isDate
  - isNativeError
  - isRegExp
- Improves:
  - isArgumentsObject
  - isExternal

PR-URL: #59692
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
github-actions Bot mentioned this pull request Oct 7, 2025
Merged
aduh95 pushed a commit that referenced this pull request Oct 11, 2025
typings: update 'types' binding
1f681ad 
- Adds:
  - isGeneratorObject
  - isProxy
  - isSharedArrayBuffer
  - isSymbolObject
- Removes:
  - isTypedArray
- Fixes:
  - isDate
  - isNativeError
  - isRegExp
- Improves:
  - isArgumentsObject
  - isExternal

PR-URL: #59692
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request Oct 11, 2025
typings: update 'types' binding
ef005d0 
- Adds:
  - isGeneratorObject
  - isProxy
  - isSharedArrayBuffer
  - isSymbolObject
- Removes:
  - isTypedArray
- Fixes:
  - isDate
  - isNativeError
  - isRegExp
- Improves:
  - isArgumentsObject
  - isExternal

PR-URL: #59692
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
github-actions Bot mentioned this pull request Oct 12, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
daeyeon daeyeon approved these changes
legendecas legendecas approved these changes
BridgeAR BridgeAR approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. typings

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL