FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: remove `AnalyzeTemporaryDtors` option from .clang-tidy by iknoom · Pull Request #60008 · nodejs/node · GitHub

/ node Public

src: remove AnalyzeTemporaryDtors option from .clang-tidy - #60008

Closed
iknoom wants to merge 1 commit into
nodejs:mainfrom
iknoom:removed-clang-tidy-option
Closed

src: remove AnalyzeTemporaryDtors option from .clang-tidy#60008
iknoom wants to merge 1 commit into
nodejs:mainfrom
iknoom:removed-clang-tidy-option

Conversation

iknoom commented Sep 25, 2025
edited
Loading

Copy link
Copy Markdown
Contributor

This PR removes AnalyzeTemporaryDtors option from .clang-tidy. This option was deprecated since clang-tidy 16 and removed in clang-tidy 18.

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Sep 25, 2025
addaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2025
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2025

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

gurgunday left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

Copy link
Copy Markdown
Collaborator

addaleax pushed a commit that referenced this pull request Oct 6, 2025
PR-URL: #60008
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

addaleax commented Oct 6, 2025

Copy link
Copy Markdown
Member

Landed in 81b7119

addaleax closed this Oct 6, 2025
targos pushed a commit that referenced this pull request Oct 6, 2025
PR-URL: #60008
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request Oct 22, 2025
PR-URL: #60008
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL