FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

crypto: avoid throwing key brand checks by panva · Pull Request #65503 · nodejs/node · GitHub

/ node Public

crypto: avoid throwing key brand checks - #65503

Open
panva wants to merge 2 commits into
nodejs:mainfrom
panva:crypto-avoid-throwing-brand-checks
ConversationCommits (2)ChecksFiles changed
Open

crypto: avoid throwing key brand checks#65503
panva wants to merge 2 commits into
nodejs:mainfrom
panva:crypto-avoid-throwing-brand-checks

Conversation

panva commented Aug 23, 2026

Copy link
Copy Markdown
Member

Use the native KeyObject and CryptoKey FunctionTemplate brand check instead of probing slot access and catching ERR_INVALID_THIS. Keep a private-field fast path for ordinary same-realm keys.

Before this change isKeyObject() and isCryptoKey() detected invalid objects by calling their slot getters, catching ERR_INVALID_THIS, and returning false. Because node:crypto APIs check key inputs for being key objects first this change has a positive downstream effect on every use of those APIs that isn't with a key object (e.g. PEM, DER, JWK, etc) as well as on use with key object embedded in an regular object as { key: KeyObject, ...options }

Operation Before After Change
createHmac() with a Buffer key 167k ops/s 622k ops/s +272%
createCipheriv() with a Buffer key 148k ops/s 594k ops/s +301%
hkdfSync() with a Buffer key 91.7k ops/s 171.6k ops/s +87%
createPublicKey() with DER options 44.8k ops/s 76.2k ops/s +70%
createPrivateKey() with DER options 29.8k ops/s 41.9k ops/s +41%
sign() with DER options 17.8k ops/s 21.9k ops/s +23%
verify() with DER options 13.4k ops/s 15.1k ops/s +13%
publicEncrypt() with options and a Buffer 22.6k ops/s 29.2k ops/s +29%
diffieHellman() with two Buffer keys 13.6k ops/s 15.5k ops/s +14%
encapsulate() / decapsulate() with a Buffer key 15.8k ops/s 17.3k ops/s +9.5%

Object-form key inputs benefit more because both the options object and its key payload previously caused failed brand checks.

SubtleCrypto operations are unaffected because they use WebIDL interface conversion instead of isCryptoKey().

panva added 2 commits August 23, 2026 18:35
crypto: avoid throwing KeyObject brand checks
5ae92ff 
Use the native KeyObject FunctionTemplate brand check instead of
probing slot access and catching ERR_INVALID_THIS. Keep a private-field
fast path for ordinary same-realm KeyObjects.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
crypto: avoid throwing CryptoKey brand checks
3d5397c 
Use the native CryptoKey FunctionTemplate brand check instead of
probing slot access and catching ERR_INVALID_THIS. Keep a private-field
fast path for ordinary same-realm CryptoKeys.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
panva requested review from anonrig and jasnell August 23, 2026 17:03
panva added crypto Issues and PRs related to the crypto subsystem. performance Issues and PRs related to the performance of Node.js. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. labels Aug 23, 2026

nodejs-github-bot commented Aug 23, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Aug 23, 2026
panva added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 23, 2026
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 23, 2026

This comment was marked as outdated.

Sign in to view

codecov Bot commented Aug 23, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.85714% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.13%. Comparing base (7d69ed1) to head (3d5397c).
⚠️ Report is 40 commits behind head on main.

Files with missing lines Patch % Lines
src/crypto/crypto_keys.cc 87.50% 0 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #65503      +/-   ##
==========================================
- Coverage   90.14%   90.13%   -0.02%     
==========================================
  Files         751      751              
  Lines      252521   252701     +180     
  Branches    47511    47552      +41     
==========================================
+ Hits       227635   227771     +136     
- Misses      16192    16210      +18     
- Partials     8694     8720      +26
Files with missing lines Coverage Δ
lib/internal/crypto/keys.js 98.02% <100.00%> (-0.02%) ⬇️
src/crypto/crypto_keys.h 62.22% <ø> (ø)
src/crypto/crypto_keys.cc 69.84% <87.50%> (+0.19%) ⬆️

... and 38 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This comment has been minimized.

Sign in to view

nodejs-github-bot commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/76354/

tniessen commented Aug 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Is there a benchmark that reflects this? If so, this should have a benchmark CI run even if I find this entirely believable as-is :)

panva commented Aug 24, 2026

Copy link
Copy Markdown
Member Author

Is there a benchmark that reflects this? If so, this should have a benchmark CI run even if I find this entirely believable as-is :)

We can't get benchmark results from Jenkins until nodejs/build#4374 is fixed. The results posted already use existing benchmarks ran using production build locally.

panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

avivkeller avivkeller approved these changes
jasnell Awaiting requested review from jasnell
anonrig Awaiting requested review from anonrig

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. crypto Issues and PRs related to the crypto subsystem. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. performance Issues and PRs related to the performance of Node.js.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL