DEP: Finalize bool(empty_array) deprecation - #27160
Conversation
Sorry, something went wrong.
This deprecation has been around for many years, let's finalize it. This means that e.g. ``bool(np.array([]))`` fails.
|
The code changes look fine to me.
That assumption seems optimistic to me :) This is a pretty easy warning to hit, so let's hold off on merging this for another few days at least to give any fallout from the RC time to show up on downstream CI. |
Sorry, something went wrong.
|
I dunno, for depcreations that are simple to fix (and years old), I think it likely holds, but I don't mind waiting either. :) |
Sorry, something went wrong.
mhvk
left a comment
There was a problem hiding this comment.
Looks good to me! (Fine to wait a bit to avoid confusion.)
Sorry, something went wrong.
|
OK, time to merge this. Thanks for the cleanup PRs Sebastian! |
Sorry, something went wrong.
This deprecation has been around for many years, let's finalize it. This means that e.g. bool(np.array([])) fails.
Some discussion also in gh-9885 (but it also discusses single element non 0-D arrays).
Closes gh-6722
I'll assume downstream that tests against nightlies avoids deprecation warnings, so that 2.1rc timing shouldn't lead to confusion.