FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

BUG: np.cov transpose control by tylerjereddy · Pull Request #27661 · numpy/numpy · GitHub

/ numpy Public

BUG: np.cov transpose control - #27661

Merged
seberg merged 1 commit into
numpy:mainfrom
tylerjereddy:treddy_issue_27658
Oct 29, 2024
ConversationCommits (1)ChecksFiles changed
Merged

BUG: np.cov transpose control#27661
seberg merged 1 commit into
numpy:mainfrom
tylerjereddy:treddy_issue_27658

Conversation

tylerjereddy commented Oct 29, 2024

Copy link
Copy Markdown
Contributor

jakevdp approved these changes Oct 29, 2024
View reviewed changes

jakevdp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good - thanks!

seberg commented Oct 29, 2024

Copy link
Copy Markdown
Member

Does this have a chance of breaking existing (bad) code in odd ways? (I.e. should we add a release note and consider probably not backport?)

jakevdp commented Oct 29, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

The bug has existed for 19 years (I tracked the behavior to 959f36c via git blame) so probably no backport is necessary. We should treat it as a behavior change rather than a typical bug fix.

ngoldbaum commented Oct 29, 2024

Copy link
Copy Markdown
Member

I agree, let's add a release note and then merge this.

ngoldbaum added the 56 - Needs Release Note. Needs an entry in doc/release/upcoming_changes label Oct 29, 2024
BUG: np.cov transpose control
e003e82 
* Fixes numpy#27658

* Use a more sensible filter for controlling
the decision to transpose the design matrix
received by `np.cov`.

* Add a release note.

tylerjereddy commented Oct 29, 2024

Copy link
Copy Markdown
Contributor Author

Ok, I added a release note/towncrier fragment (amending the original commit since the diff is so small here).

The release note looks like this locally via spin docs:

seberg commented Oct 29, 2024

Copy link
Copy Markdown
Member

Thanks Tyler and Jake!

seberg merged commit 8145832 into numpy:main Oct 29, 2024
tylerjereddy deleted the treddy_issue_27658 branch October 29, 2024 18:41
tylerjereddy added this to the 2.2.0 release milestone Oct 29, 2024
WarrenWeckesser mentioned this pull request Oct 29, 2024
Closed
EarlMilktea mentioned this pull request Dec 18, 2024
Merged
jakevdp mentioned this pull request Jun 19, 2025
Closed
DanisNone mentioned this pull request Jun 20, 2025
Closed
mmccarty mentioned this pull request Oct 2, 2025
Merged
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
jakevdp jakevdp approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

00 - Bug 56 - Needs Release Note. Needs an entry in doc/release/upcoming_changes component: numpy.lib

Projects

None yet

Milestone

2.2.0 release

Development

Successfully merging this pull request may close these issues.

BUG: np.cov with rowvar=False returns the wrong shape for N=1

4 participants

Back | FazBrowse Home | New Git URL