ENH: Adopt _simd for multi-phase module initialization - #32335
Open
prathamhole14 wants to merge 1 commit into
Open
ENH: Adopt _simd for multi-phase module initialization#32335prathamhole14 wants to merge 1 commit into
prathamhole14 wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
prathamhole14
commented
Aug 27, 2026
Comment thread
numpy/_core/src/_simd/_simd.c
|
|
||
| static PyModuleDef_Slot _simd_slots[] = { | ||
| {Py_mod_exec, _simd_exec}, | ||
| #if PY_VERSION_HEX >= 0x030c00f0 // Python 3.12+ |
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
This is dead code, maybe in another PR all instances like this can be removed? Please let me know.
Sorry, something went wrong.
prathamhole14
marked this pull request as ready for review
August 27, 2026 11:31
Copy link
Copy Markdown
Contributor
Author
|
Failing tests are unrelated. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
As titled, please see #32451, I have followed this https://docs.python.org/3/c-api/extension-modules.html doc.
Related to: #29021
AI Disclosure
In re-reviewing the PR with claude opus 5 and writing comments.