Add convenience method setAttribute(Attribute<Long>, int) to SpanBuilder (matching the existing convenience method in Span) - #6884
Merged
jack-berg merged 5 commits intoNov 18, 2024
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
|
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
/easycla |
Sorry, something went wrong.
1 similar comment
Copy link
Copy Markdown
Member
|
/easycla |
Sorry, something went wrong.
Stoyas
force-pushed
the
B2-6870-fixbuilder
branch
from
70de66c to
0deb45b
Compare
November 16, 2024 00:11
Copy link
Copy Markdown
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files @@ Coverage Diff @@
## main #6884 +/- ##
============================================
- Coverage 90.30% 90.29% -0.02%
Complexity 6589 6589
============================================
Files 729 729
Lines 19767 19768 +1
Branches 1944 1944
============================================
- Hits 17851 17849 -2
- Misses 1325 1327 +2
- Partials 591 592 +1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Sorry, something went wrong.
breedx-splk
approved these changes
Nov 16, 2024
breedx-splk
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM. Thanks!
Sorry, something went wrong.
trask
approved these changes
Nov 16, 2024
Comment thread
api/all/src/main/java/io/opentelemetry/api/trace/SpanBuilder.java
Outdated
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
jack-berg
approved these changes
Nov 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #6870