Add synchronization to SimpleLogRecordProcessor and SimpleSpanProcessor to ensure thread-safe export of logs and spans respectively - #6885
Merged
jack-berg merged 1 commit intoNov 18, 2024
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
The committers listed above are authorized under a signed CLA. |
Sorry, something went wrong.
…or to ensure thread-safe export of logs and spans respectively
slodha
force-pushed
the
slodha.issue-6681
branch
from
f8521a9 to
c56de26
Compare
November 16, 2024 00:19
breedx-splk
approved these changes
Nov 16, 2024
Copy link
Copy Markdown
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files @@ Coverage Diff @@
## main #6885 +/- ##
=========================================
Coverage 90.30% 90.31%
Complexity 6589 6589
=========================================
Files 729 729
Lines 19767 19773 +6
Branches 1944 1944
=========================================
+ Hits 17851 17857 +6
Misses 1325 1325
Partials 591 591 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Sorry, something went wrong.
trask
approved these changes
Nov 16, 2024
trask
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
thanks!
Sorry, something went wrong.
jack-berg
approved these changes
Nov 18, 2024
jack-berg
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #6681