Add event name as an incubating feature - #7012
Merged
jack-berg merged 5 commits intoJan 16, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
trask
force-pushed
the
event-name
branch
4 times, most recently
from
d65288c to
fa6196b
Compare
January 13, 2025 22:31
trask
force-pushed
the
event-name
branch
5 times, most recently
from
fb22190 to
6fadc54
Compare
January 13, 2025 23:18
Copy link
Copy Markdown
Codecov ReportAttention: Patch coverage is 68.62745% with 16 lines in your changes missing coverage. Please review.
@@ Coverage Diff @@
## main #7012 +/- ##
============================================
- Coverage 89.95% 89.89% -0.06%
- Complexity 6635 6643 +8
============================================
Files 745 746 +1
Lines 20010 20059 +49
Branches 1962 1968 +6
============================================
+ Hits 17999 18032 +33
- Misses 1415 1431 +16
Partials 596 596 ☔ View full report in Codecov by Sentry. |
Sorry, something went wrong.
trask
marked this pull request as ready for review
January 13, 2025 23:42
jack-berg
approved these changes
Jan 14, 2025
jack-berg
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Couple minor comments, but looks good.
Sorry, something went wrong.
Comment thread
api/incubator/src/main/java/io/opentelemetry/api/incubator/logs/ExtendedLogRecordBuilder.java
Comment thread
sdk/logs/src/main/java/io/opentelemetry/sdk/logs/SdkLogRecordData.java
Outdated
Comment thread
sdk/logs/src/main/java/io/opentelemetry/sdk/logs/data/internal/ExtendedLogRecordData.java
Outdated
…ata.java Co-authored-by: jack-berg <34418638+jack-berg@users.noreply.github.com>
breedx-splk
approved these changes
Jan 14, 2025
breedx-splk
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Onward! 🚀
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.