Allow Otlp*MetricExporter's to publish export stats - #7255
Conversation
Sorry, something went wrong.
Previously there was no way to report stats for otlp metric exporters. Now we can supply a MeterProvider lazily. When export is invoked if the previously provided meter is a noop implementation it will try again, allowing for delayed/lazy initialization.
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files @@ Coverage Diff @@
## main #7255 +/- ##
=========================================
Coverage 89.60% 89.61%
- Complexity 6859 6868 +9
=========================================
Files 780 780
Lines 20728 20739 +11
Branches 2018 2018
=========================================
+ Hits 18574 18585 +11
Misses 1514 1514
Partials 640 640 ☔ View full report in Codecov by Sentry.
|
Sorry, something went wrong.
jack-berg
left a comment
There was a problem hiding this comment.
Thanks!
You'll also want to make sure OtlpMetricExporterProvider implementation follows the pattern of setting the meter provider using the AutoConfigureListener callback, following the example of logs and spans. e.g.: https://github.com/open-telemetry/opentelemetry-java/blob/main/exporters/otlp/all/src/main/java/io/opentelemetry/exporter/otlp/internal/OtlpLogRecordExporterProvider.java#L32-L99
Sorry, something went wrong.
|
Thanks! Will merge after the conflict is resolved |
Sorry, something went wrong.
# Conflicts: # exporters/otlp/all/src/test/java/io/opentelemetry/exporter/otlp/http/metrics/OtlpHttpMetricExporterBuilderTest.java
Previously there was no way to report stats for otlp metric exporters.
Now we can supply a MeterProvider lazily. When export is invoked if the previously provided meter is a noop implementation it will try again, allowing for delayed/lazy initialization.