Add DeclarativeConfigContext - #7293
Merged
jack-berg merged 2 commits intoMay 6, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov ReportAttention: Patch coverage is 91.26214% with 9 lines in your changes missing coverage. Please review.
@@ Coverage Diff @@
## main #7293 +/- ##
============================================
- Coverage 90.04% 89.86% -0.19%
+ Complexity 6916 6890 -26
============================================
Files 787 786 -1
Lines 20864 20771 -93
Branches 2023 2024 +1
============================================
- Hits 18788 18666 -122
- Misses 1439 1463 +24
- Partials 637 642 +5 ☔ View full report in Codecov by Sentry.
|
Sorry, something went wrong.
jaydeluca
approved these changes
May 3, 2025
Comment thread
.../main/java/io/opentelemetry/sdk/extension/incubator/fileconfig/DeclarativeConfigContext.java
Outdated
| } | ||
|
|
||
| /** | ||
| * Find a registered {@link ComponentProvider} which {@link ComponentProvider#getType()} matching |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Suggested change
| * Find a registered {@link ComponentProvider} which {@link ComponentProvider#getType()} matching | |
| * Find a registered {@link ComponentProvider} with {@link ComponentProvider#getType()} matching |
Sorry, something went wrong.
trask
approved these changes
May 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor declarative config to encapsulate config context and state into a new carrier object, DeclarativeConfigContext.
Benefits: