FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Require explanations for suppressed warnings in OTLP profiles exporter by thswlsqls · Pull Request #8747 · open-telemetry/opentelemetry-java · GitHub

/ opentelemetry-java Public

Require explanations for suppressed warnings in OTLP profiles exporter - #8747

Open
thswlsqls wants to merge 1 commit into
open-telemetry:mainfrom
thswlsqls:refactor/profiles-require-suppress-warnings-explanation
ConversationCommits (1)ChecksFiles changed
Open

Require explanations for suppressed warnings in OTLP profiles exporter#8747
thswlsqls wants to merge 1 commit into
open-telemetry:mainfrom
thswlsqls:refactor/profiles-require-suppress-warnings-explanation

Conversation

thswlsqls commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Related to #7874

Description

  • Require explanations for suppressed warnings in logging OTLP #8741 enabled the SuppressWarningsWithoutExplanation ErrorProne check for exporters/logging-otlp and added a temporary opt-out to every other module. This does the same for :exporters:otlp:profiles.
  • Removes otelJava.requireSuppressWarningsExplanation.set(false) from build.gradle.kts, so the default convention(true) applies.
  • Adds an explanation to the @SuppressWarnings("unchecked") in ProfilesRequestMarshalerTest#parse, the one suppression here the check flags. Same form as the comments Require explanations for suppressed warnings in logging OTLP #8741 added.
  • The module's other two suppressions (ReferenceEquality, AvoidObjectArrays) are out of scope: the check only flags deprecation, rawtypes and unchecked.
  • This covers one module, so the issue stays open.

Testing done

  • Build flag and one comment only, so no test added.
  • ./gradlew :exporters:otlp:profiles:check — BUILD SUCCESSFUL.
  • Confirmed the check is live: with the flag removed but the comment reverted, compileTestJava fails with one SuppressWarningsWithoutExplanation error, at ProfilesRequestMarshalerTest.java:475.
  • No apidiff change: alpha artifact, public API untouched.

thswlsqls marked this pull request as ready for review August 25, 2026 12:53
thswlsqls requested a review from a team as a code owner August 25, 2026 12:53

opentelemetry-pr-dashboard Bot commented Aug 25, 2026 •
edited
Loading

Copy link
Copy Markdown

Pull request dashboard status

Waiting on reviewers · refreshed 2026-08-25 13:24 UTC

Review the latest changes.

Status above doesn't look right?
  • Just replied or pushed? Anything around or after the refresh time above may not be picked up yet — give it a few minutes.
  • Anything look wrong? Report it with what you expected; it helps us improve the dashboard.

opentelemetry-pr-dashboard Bot mentioned this pull request Aug 25, 2026
Open

codecov Bot commented Aug 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.29%. Comparing base (e2efec5) to head (2160866).

Additional details and impacted files 
@@            Coverage Diff            @@
##               main    #8747   +/-   ##
=========================================
  Coverage     91.29%   91.29%           
  Complexity    10498    10498           
=========================================
  Files          1006     1006           
  Lines         28338    28338           
  Branches       3581     3581           
=========================================
  Hits          25870    25870           
  Misses         1675     1675           
  Partials        793      793

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

Back | FazBrowse Home | New Git URL