Simplify ON keyword check to only needed case - #652
Open
predictor2718 wants to merge 2 commits into
Open
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Signed-off-by: Nicolai Ehrhardt <245527909+predictor2718@users.noreply.github.com>
Copy link
Copy Markdown
Codecov Report❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
@@ Coverage Diff @@
## 5.11.x #652 +/- ##
============================================
- Coverage 96.92% 96.90% -0.02%
- Complexity 2316 2319 +3
============================================
Files 71 71
Lines 5110 5112 +2
============================================
+ Hits 4953 4954 +1
- Misses 157 158 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
Sorry, something went wrong.
Signed-off-by: Nicolai Ehrhardt <245527909+predictor2718@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expression::parse() rejected
it is valid in SET statements
Fixes #627