Fix #655 - Missing space before UNION when building CREATE VIEW - #656
Open
predictor2718 wants to merge 1 commit into
Open
Fix #655 - Missing space before UNION when building CREATE VIEW#656predictor2718 wants to merge 1 commit into
predictor2718 wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…VIEW Signed-off-by: predictor2718 <245527909+predictor2718@users.noreply.github.com>
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## 5.11.x #656 +/- ##
=========================================
Coverage 96.92% 96.93%
- Complexity 2316 2320 +4
=========================================
Files 71 71
Lines 5110 5114 +4
=========================================
+ Hits 4953 4957 +4
Misses 157 157
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sorry, something went wrong.
williamdes
approved these changes
Apr 25, 2026
williamdes
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #655.
CreateStatement::build() glued the built SELECT directly to the trailing body
tokens when rebuilding a CREATE VIEW ... AS SELECT ... UNION ..., producing
invalid SQL like ... WHERE 3 = 3union all (...).
Insert a single space between $builtStatement and the body tokens only when
both sides are non-empty and neither boundary character is whitespace, so the
paren-wrapped LHS case (AS (select ...) union all (...)) doesn't get a double
space.
Includes a regression test in tests/Builder/CreateStatementTest.php.
Also addresses phpMyAdmin reports:
Signed-off-by: predictor2718 245527909+predictor2718@users.noreply.github.com