feat: support optimizeEmptyRequests node option handling - #154
Open
bjohansebas wants to merge 1 commit into
Open
feat: support optimizeEmptyRequests node option handling#154bjohansebas wants to merge 1 commit into
bjohansebas wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
finalhandler is used as a callback in the router's handler when there’s no error handler or callback (https://github.com/expressjs/express/blob/2eb42059f33d9be6ead3bb813d05aa975283d592/lib/application.js#L154), and for some reason, the response wasn’t finishing. When I realized it, the on-finished callback was never triggered (
finalhandler/index.js
Line 291 in 62cc7e0
finalhandler/index.js
Line 282 in 62cc7e0
ref: https://openjs-foundation.slack.com/archives/C08QG8K2RTJ/p1757863264523329
ref: expressjs/express#6742