fix(node): install git hooks as real directories - #3741
Closed
vetrovk wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3737.
After the switch to git-based npm installation, a workspace package could remain a symlink to npm's temporary _cacache/tmp/git-clone... directory. Once npm removed that temporary clone, the installed hook executable was no longer available.
Pass --install-links=true for this installation so npm materializes the package. Add a regression test using a workspace package.
Validation:
mypy did not pass because of a macOS-specific sched_getaffinity error. The same failure reproduces on the clean upstream commit 242ce8a, so it is unrelated to this patch.