Accept SHA-256 all-zero OIDs in pre-push deletion detection - #3781
Closed
Eryx-Z wants to merge 1 commit into
Closed
Eryx-Z wants to merge 1 commit into
Eryx-Z wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Git SHA-256 repos emit a 64-character zero OID for deletion pushes. Hardcoding only the SHA-1 40-zero form made `git push --delete` fail with Invalid revision range errors. Fixes pre-commit#3664.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pre_commit/commands/hook_impl.py hardcoded Z40 = '0' * 40 for deletion / new-branch detection on pre-push. SHA-256 repositories emit a 64-character zero OID, so git push --delete fell through into git diff against the zero OID and failed.
Accept an all-zero OID of length 40 or 64 via _is_zero_oid().
Fixes #3664.
Test plan