fix tox -e py37 in CONTRIBUTING.md - #3782
Closed
HyperionBurn wants to merge 1 commit into
Closed
HyperionBurn wants to merge 1 commit into
HyperionBurn wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
pre-commit requires Python 3.11 or later (setup.cfg sets python_requires = >=3.11), so a Python 3.7 tox environment can no longer be built. The envlist in tox.ini is `py, pypy3, pre-commit`, so `tox -e py` is the environment that runs the full test suite.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CONTRIBUTING.md told contributors to run the full test suite with tox -e py37, but that environment can no longer be built: setup.cfg declares python_requires = >=3.11, so Python 3.7 cannot install pre-commit at all.
The environment that actually runs the suite is py, from the envlist in tox.ini:
This changes only that one command; the surrounding advice is unchanged.
Verified against main at 20b1e7c:
The related tox --devenv venv instruction above it is still accurate, so I left it alone.