Fix autoupdate parsing without trailing newline - #3784
Closed
Niranjan-png wants to merge 6 commits into
Closed
Niranjan-png wants to merge 6 commits into
Niranjan-png wants to merge 6 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
for more information, see https://pre-commit.ci
…501 line length violations
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #3768 where autoupdate drops comments when the rev line is last and the file has no final newline. The regex REV_LINE_RE in autoupdate.py was updated to allow missing final newline by changing to . Added regression test covering LF, CRLF, missing final newline, and final newline cases.