JSX/TSX: treat non-ASCII characters in JSX text as text - #3277
Open
ekanshul wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
JSX text content is lexed with the JavaScript rules, which have no rule for symbols outside ASCII, so arrows, dashes, curly quotes and emoji in element content (<li>Star -> Slack</li>) produced Error tokens. Add a fallback after the inherited rules, next to the existing apostrophe fallback, so identifiers with non-ASCII letters keep being lexed by the JavaScript identifier rule first. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSX element content is lexed with the plain JavaScript rules, which have no rule for characters outside ASCII that are not identifier letters. So arrows, dashes, curly quotes, bullets and emoji in text content, e.g.
each produce an Error token. In a real Next.js codebase these were 70 of the 336 Error tokens across its .tsx files (the rest are the type-argument issue addressed in #3272).
The JSX/TSX lexers already append a fallback rule after the inherited JavaScript rules for the apostrophe in text (<div>I'm here</div>); this adds a sibling fallback for runs of non-ASCII characters, emitted as Text. Because it comes after inherit, identifiers containing non-ASCII letters (const café = 1) are still matched by the JavaScript identifier rule first. Independent of #3272.