Repository navigation
gh-119180: Use type descriptors to access annotations (PEP 749) - #122074
Merged
JelleZijlstra merged 140 commits intoJul 27, 2024
Merged
JelleZijlstra merged 140 commits into
JelleZijlstra merged 140 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
21 of 30 tasks
This was referenced Jul 23, 2024
carljm
approved these changes
Jul 26, 2024
carljm
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Looks great!
Sorry, something went wrong.
Comment thread
Lib/annotationlib.py
| Returns the __annotate__ function or None. | ||
| """ | ||
| if isinstance(obj, type): | ||
| return _BASE_GET_ANNOTATE(obj) |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
It may be worth explaining, in a comment or docstring (here or somewhere) why we have to go to these odd lengths.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
Good point, will do that. Thanks for reviewing!
Sorry, something went wrong.
JelleZijlstra
enabled auto-merge (squash)
July 27, 2024 16:13
JelleZijlstra
added a commit
to JelleZijlstra/typing_extensions
that referenced
this pull request
Jul 27, 2024
Tests from python/cpython#122074. We don't have to use the base descriptor approach here because we find the annotations directly in the `__dict__` for the class, which avoids metaclass problems.
JelleZijlstra
added a commit
to python/typing_extensions
that referenced
this pull request
Sep 23, 2024
Tests from python/cpython#122074. We don't have to use the base descriptor approach here because we find the annotations directly in the `__dict__` for the class, which avoids metaclass problems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A third alternative to #120719 and #120816. See python/peps#3847 (comment).
This PR is on top of #119891.
📚 Documentation preview 📚: https://cpython-previews--122074.org.readthedocs.build/